Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation for ACL in cluster connect #1259

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: documentation for ACL in cluster connect #1259

merged 1 commit into from
Oct 27, 2021

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Oct 27, 2021

Documentation was changed to print example. not actual instruction as commands will be dependent on the service you have been working with.

Comment on lines +166 to +170
NOTE: Created service account will need to be given permissions to specified service
For example for Kafka service you should execute the following command to grant access to the service account

$ rhoas kafka acl grant-access --producer --consumer --service-account your-sa --topic "*" --group "*"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into a separate i18n message and only print it when the service is Kafka?

@craicoverflow craicoverflow self-requested a review October 27, 2021 12:00
@wtrocki wtrocki merged commit 8263b06 into main Oct 27, 2021
@wtrocki wtrocki deleted the connect-docs branch October 27, 2021 12:06
@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 27, 2021

Separate issue created: #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants