Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to the kafka topics command to ignore invalid/self signed certs #122

Closed
wtrocki opened this issue Dec 4, 2020 · 3 comments · Fixed by #127
Closed

Add flag to the kafka topics command to ignore invalid/self signed certs #122

wtrocki opened this issue Dec 4, 2020 · 3 comments · Fixed by #127

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Dec 4, 2020

Just investigate if that is possible.

@craicoverflow
Copy link
Contributor

I investigated if this is possible and yes, it is.

https://github.com/bf2fc6cc711aee1a0c2a/cli/blob/1861ac5efa8b8bc91cd77c101a0fcc30d8544c4e/pkg/sdk/kafka/topics/topics.go#L23-L27

A TLS flag can be passed here to allow insecure connections:

dialer := &kafka.Dialer{
	Timeout:   100 * time.Second,
	DualStack: true,
	// #nosec 402
	TLS: &tls.Config{
		InsecureSkipVerify: insecure,
	},
}

@wtrocki
Copy link
Collaborator Author

wtrocki commented Dec 7, 2020

Adding rhoas kafka topic sticky unsecure flag would be amazing and allow us to work with production backend

@craicoverflow
Copy link
Contributor

Yes, and I tried using Cobra persistent flags to achieve this but they did not behave as I expected them to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants