feat: added an option to show bootstrap server host of the Kafka instance #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
suggested changes
Sep 10, 2021
Thanks for the feedback. I've made the changes, please take a look. |
wtrocki
approved these changes
Sep 12, 2021
wtrocki
reviewed
Sep 13, 2021
| @@ -402,6 +402,13 @@ one = 'Unique ID of the Kafka instance you want to view' | |||
| description = 'Description for the --name flag' | |||
| one = 'Name of the Kafka instance you want to view' | |||
|
|
|||
| [kafka.describe.flag.bootstrapserver] | |||
There was a problem hiding this comment.
In long run we want to have ability to get some specific config of the services in unified fassion.
It is good to have this in describe for now, but we should have similar capability for the status command
|
LGTM |
|
Reverified. Good job! |
wtrocki
reviewed
Sep 13, 2021
wtrocki
requested changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #636