Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: made Context a part of the factory object #1053

Merged
merged 1 commit into from
Sep 9, 2021
Merged

feat: made Context a part of the factory object #1053

merged 1 commit into from
Sep 9, 2021

Conversation

alexal
Copy link
Contributor

@alexal alexal commented Sep 9, 2021

Closes #1001

@wtrocki
Copy link
Collaborator

wtrocki commented Sep 9, 2021

Reviewing

@alexal
Copy link
Contributor Author

alexal commented Sep 9, 2021

Reviewing

Thanks. I did run a few commands, and they seem to be working :-D

@wtrocki
Copy link
Collaborator

wtrocki commented Sep 9, 2021

problem is that I want to see if all occurences of context were replaced etc. looks good

@wtrocki wtrocki merged commit eae4a85 into redhat-developer:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context should be part of the factory object
2 participants
@alexal @wtrocki