feat: emoji support for both error and success messages #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
A couple of nits, but I will resolve them in a micro-PR follow up as I'd love to get this merged and begin using it. Thnk you so much @alexal!
| @@ -255,7 +256,7 @@ func runCreate(opts *Options) error { | |||
|
|
|||
| if !opts.wait { | |||
| opts.Logger.Info() | |||
| opts.Logger.Info(opts.localizer.MustLocalize("kafka.create.info.successAsync", nameTemplateEntry)) | |||
| opts.Logger.Info(icon.Success(), opts.localizer.MustLocalize("kafka.create.info.successAsync", nameTemplateEntry)) | |||
There was a problem hiding this comment.
I wouldn't put the icon here, because the Kafka instance is being created, and could fail, so the icon might be a false indicator.
| @@ -112,5 +113,5 @@ func initConfig(f *factory.Factory) error { | |||
| } | |||
|
|
|||
| func wrapErrorf(err error, localizer localize.Localizer) error { | |||
| return fmt.Errorf("Error: %w. %v", err, localizer.MustLocalize("common.log.error.verboseModeHint")) | |||
| return fmt.Errorf("%v %w. %v", icon.Error(), err, localizer.MustLocalize("common.log.error.verboseModeHint")) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("%v %w. %v", icon.Error(), err, localizer.MustLocalize("common.log.error.verboseModeHint")) | |
| return fmt.Errorf("%v %w. %v", icon.Error(), err, localizer.MustLocalize("common.log.error.verboseModeHint")) |
There should only be one space here
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1025
Closes #1024