chore: i18n support for service registry art Artifact commands #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
changed the title
|
WOW :) Edit: I'm speechless. Amazing PR definietly nothing like good first issue. Thank you so much for putting so much effort into RHOAS CLI |
wtrocki
reviewed
Sep 2, 2021
| rhoas service-registry artifact create --type=JSON my-artifact.json | ||
| `, | ||
| Args: cobra.RangeArgs(0, 1), | ||
| Use: f.Localizer.MustLocalize("artifact.cmd.create.use"), |
There was a problem hiding this comment.
I did not internationalise use but I think we aren't consistent in this across cli.
Command names should not change
There was a problem hiding this comment.
Let me know if you want to revert strings for "use".
There was a problem hiding this comment.
No need. All good. Changes like this should be cli wide.
wtrocki
approved these changes
Sep 2, 2021
|
@wtrocki you're welcome. Let me know if something needs to be changed. |
rkpattnaik780
pushed a commit
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #904