fix(topic): only return error on http.StatusOK #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wtrocki I think we should backport this fix to a 0.27.1 - since we now already have 0.28.0-alpha1. |
|
👀 |
|
Ignore alpha (I can remove it if needed). This should be released as hotfix. There were no significant changes on main so we might even release entire main as 0.27.1? |
|
Weird stuff happening with the build failing on documentation check. https://github.com/redhat-developer/app-services-cli/runs/3474949371 |
|
Rebase will fix it |
The topic name validator should only be returning an error when this topic name already exists.
craicoverflow
force-pushed
the
topic-create-name-interactive
branch
from
8f8863b to
d0ca314
Compare
wtrocki
approved these changes
Sep 1, 2021
|
Verified. |
rkpattnaik780
pushed a commit
that referenced
this pull request
Sep 20, 2021
The topic name validator should only be returning an error when this topic name already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topic name validator should only be returning an error
when this topic name already exists.
Closes #1003
Verification Steps
rhoas kafka createType of change
Checklist