Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-cop - want renovate bot enabling? #624

Closed
garethahealy opened this issue Nov 20, 2023 · 7 comments
Closed

ansible-cop - want renovate bot enabling? #624

garethahealy opened this issue Nov 20, 2023 · 7 comments

Comments

@garethahealy
Copy link
Contributor

@djdanielsson @ericzolf @mophahr @vvaldez

As per the below, you are called out as maintainers for the automation-cop related repos.

I've been testing out renovate on a single repo with this org, and feel it might be useful to others.

Would you like it enabled for the below repos?

It's controlled via config that lives with the source, so once it's enabled, it's up to you how it runs/what it checks.

@garethahealy
Copy link
Contributor Author

@Tompage1994 you are not on the admin/maintainers list, but know you are active here

@Tompage1994
Copy link

@garethahealy for the stuff that sits under automation-cop-tower-mgrs (The controller, ah, eda, aap_utilities, ee_utilities collections) are dependency agnostic and have no requirements.yml (or similar) so IMO won't do anything useful for them. Unsure about any of the other stuff under the group though there does seem to be galaxy and galaxy_collections as datasources for this so each repo would need to be validated.

@djdanielsson
Copy link
Contributor

djdanielsson commented Nov 20, 2023

at first when I looked at this it gave a list of languages that it supported and I didn't see Ansible on there but I see that it does seem to work with it. so it might be useful to add.

@ericzolf
Copy link
Contributor

Because it took me a while to understand what you meant: the docs list Galaxy (I can only guess roles) and Galaxy Collection as data sources.

Sadly it doesn't support custom registries, so not so useful for our customers, but possibly good enough for our collections. Yeah, we should look into it, I've added the point to our next CoP meeting.

@jeichler
Copy link

Because it took me a while to understand what you meant: the docs list Galaxy (I can only guess roles) and Galaxy Collection as data sources.

Sadly it doesn't support custom registries, so not so useful for our customers, but possibly good enough for our collections. Yeah, we should look into it, I've added the point to our next CoP meeting.

There's an open PR (after the PR to move to galaxy api v3 was now finally merged 2 weeks back) that should
a) allow custom registries
b) support PAH

I use the renovate bot for my EE's (including modifications for conventional commits :D) - happy to help here.

@garethahealy
Copy link
Contributor Author

@djdanielsson ; got a repo in mind to test against?

@ericzolf
Copy link
Contributor

After some discussion during the CoP meeting, we couldn't identify a repository where we explicitly depend on specific versions of collections, so it's probably not a topic for now. This said, if you want to enable it, we don't mind but it will probably turn empty. And it's definitely a useful piece of knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants