Update to builder v3 #112
Merged
Update to builder v3 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
force-pushed
the
v3_update
branch
from
46d34e7 to
030e09f
Compare
sean-m-sullivan
force-pushed
the
v3_update
branch
2 times, most recently
from
bd4e07b to
0e65c96
Compare
sean-m-sullivan
force-pushed
the
v3_update
branch
from
0e65c96 to
78d2d44
Compare
djdanielsson
approved these changes
Jun 27, 2023
branic
reviewed
Jun 27, 2023
djdanielsson
requested changes
Jun 27, 2023
sean-m-sullivan
force-pushed
the
v3_update
branch
8 times, most recently
from
74611f7 to
d998d8c
Compare
sean-m-sullivan
force-pushed
the
v3_update
branch
from
d998d8c to
86d52b7
Compare
There was a problem hiding this comment.
it's still failing tests does it require a merge before that will pass now? @sean-m-sullivan
djdanielsson
approved these changes
Jun 28, 2023
|
No clue on if it will magically work after merge, I've tried multiple things and am exasperated at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Complete rewrite of the builder role, venv role update to match the new strucuture to come.
How should this be tested?
playbooks are provided for testing, I've tested it with multiple options getting the jinja correct,