Update integration test dependencies #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the python environment used for integration testing for chart-verifier to more closely match the helm certification repositories. I decided not to pursue rewriting integration tests in Go for the moment given that the scripts that are in project are also used in GHA. In effect, if/when I decide to replace those, I'll move GHA first. I didn't want to change all of this at once (this PR already contains plenty of changes).
Notable:
scripts/requirements.txt contains many version updates. This is a one-off large update, but dependabot is being integrated to manage updates more frequently and in smaller doses over time.
.github/actions/setup-python/, merged #448, is being called throughout our workflows. It's intending to simplify how many times we have to specify the python version we use through actions. Mostly a PoC, but works identically to what we had before. We can use pyproject.toml in the future for this, but if we migrated the current value from setup.cfg to pyproject, we'd have a
>=instead of a pinned version - so for now, I'll pin the version and we can re-evaluate if we want to use the pyproject value to pass into setup-python.pyproject.toml is being added, and related configurations (e.g. setup.cfg) are updated to support its use. Eventually this will be followed with a python version bump.
.github/dependabot.yml is being updated to enable dependabot updates for the pip ecosystem.
chart_good.feature / chart_test.py have both been updated to account for new changes in both pytest and pytest-bdd. Notably, Feature examples are no longer supported. We got "matrix" style testing that way, so for now, I've just replicated this by adding an extra Example column.