Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present unavailable workload resources when a timeout is hit #424

Closed
komish opened this issue Feb 9, 2024 · 1 comment
Closed

Present unavailable workload resources when a timeout is hit #424

komish opened this issue Feb 9, 2024 · 1 comment
Assignees

Comments

@komish
Copy link
Contributor

komish commented Feb 9, 2024

We tell the user that workload resources were unavailable (causing a timeout) but don't tell them what resources were unavailable:

if len(unavailableWorkloadResources) > 0 {
errorMsg := "error unavailable workload resources, timeout has expired, please consider increasing the timeout using the chart-verifier --timeout flag"
utils.LogError(errorMsg)
return errors.New(errorMsg)
}

It would make sense to at least let them know which resource that we checked did not get ready in time.

@rocrisp
Copy link

rocrisp commented Mar 21, 2024

Yep! I agree. Can you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants