Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify the source of the unused linting warning for setOverridesFlag #322

Closed
komish opened this issue Apr 3, 2023 · 1 comment · Fixed by #421
Closed

Identify the source of the unused linting warning for setOverridesFlag #322

komish opened this issue Apr 3, 2023 · 1 comment · Fixed by #421

Comments

@komish
Copy link
Contributor

komish commented Apr 3, 2023

In cmd/verify.go https://github.com/redhat-certification/chart-verifier/blob/main/cmd/verify.go#L47, the setOverridesFlag triggers golangci-lint because it's unused.

We should verify that it's unused, try to find places where its use is intended but disconnected, and decide to either wire it in or remove it. Worth checking the commit where it was introduced, and any commits thereafter to see how it has been manipulated.

@dcurran90
Copy link
Contributor

after some investigation it looks like this is the commit which removed the references to the "setOverridesFlag"
Seems as though it pretty much just replaces "setOverridesFlag" with "verifyOpts.values" and missed removing the initial reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants