Add create_task function #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzionpour
requested review from
kobihk,
aradz1997,
AvivLiberman,
Asafh7,
avraham1992,
mgold1234,
natifridman and
nunnatsa
and removed request for
kobihk and
aradz1997
avraham1992
previously approved these changes
Nov 25, 2021
aradz1997
previously approved these changes
Nov 25, 2021
kobihk
requested changes
Nov 25, 2021
orzionpour
dismissed stale reviews from aradz1997 and avraham1992
via
6a544b2
AvivLiberman
requested changes
Nov 26, 2021
|
I know, I'm on it. |
orzionpour
changed the title
orzionpour
force-pushed
the
add-create-task
branch
from
6a544b2 to
9138a1f
Compare
- Add a function "create_task" to add task to DB - Add tests for the above function Co-Authored-By: Kobi Hakimi <[email protected]>
orzionpour
force-pushed
the
add-create-task
branch
from
9138a1f to
c1f2ad1
Compare
|
Sorry for the force push, had some issues with update from main .. |
orzionpour
changed the title
AvivLiberman
requested changes
Nov 26, 2021
Asafh7
previously approved these changes
Nov 27, 2021
|
Please change the PR description to be meaningful. For example: "this PR adds the ability to ..." or "this PR fixes a bug where ..." or "this PR changes the way we do ... because ..." |
|
Done |
aradz1997
previously approved these changes
Nov 27, 2021
|
Pulled changes from main and resolved conflicts |
kobihk
requested changes
Nov 28, 2021
Asafh7
previously approved these changes
Nov 28, 2021
Change the negative tests of create_task to be one parameterized test.
Merged
aradz1997
approved these changes
Nov 29, 2021
Asafh7
approved these changes
Nov 29, 2021
|
@orzionpour Let us know which one you want to merge first. #74 or #83 |
|
@natifridman doesn’t matter which one, after merging one of them i’ll let you know when the second is ready. Thanks |
natifridman
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
This PR adds the ability to create new tasks and save them to the DB.
Changes you made
- Add a function "create_task" to add task to DB
This function add the ability to create a new task and save it to DB.
- Add tests for the above function