Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan loading issues #55

Closed
HaNdTriX opened this issue Apr 7, 2020 · 6 comments
Closed

Plan loading issues #55

HaNdTriX opened this issue Apr 7, 2020 · 6 comments
Labels

Comments

@HaNdTriX
Copy link
Contributor

HaNdTriX commented Apr 7, 2020

Describe the bug

When using the following forked codesandbox example with my personal RECURLY_PUBLIC_KEY I am getting the following error:

Screenshot 2020-04-07 at 11 53 34

To Reproduce

  1. Open: https://codesandbox.io/s/bold-tdd-idghq?file=/src/checkout-pricing.js
  2. Go to "Checkout Pricing"
  3. Select a plan
  4. Check the console

Expected behavior

  • A. Should show the price
  • B. Or at least show an error

Your Environment

  • Which version of react-recurly are you using? `@recurly/[email protected]
  • Which version of react are you using? [email protected]
  • Which browser (+version) are you using? Chrome Version 80.0.3987.163 (Official Build) (64-bit)
@HaNdTriX HaNdTriX added the bug? label Apr 7, 2020
@dbrudner dbrudner added bug and removed bug? labels Apr 7, 2020
@dbrudner
Copy link
Contributor

dbrudner commented Apr 7, 2020

Great reporting, this looks like a bug. We'll look into this, thanks for posting.

@dbrudner
Copy link
Contributor

dbrudner commented Apr 7, 2020

@HaNdTriX We started taking a look at this today and will begin working on a fix soon. I'll make sure to continue to give you updates as we learn more. Big thanks again for reporting and providing a reproduction.

@dbrudner
Copy link
Contributor

@HaNdTriX Just to follow up, we have a fix for this issue and will be releasing it soon. Thanks for your patience!

@dbrudner
Copy link
Contributor

dbrudner commented May 5, 2020

@HaNdTriX we just released a fix for this in v1.2.0. It should be noted that we released a patch version immediately after that release and the latest version is v1.2.1.

Here's a working codesandbox with the issue fixed https://codesandbox.io/s/boring-napier-9gxog?file=/src/checkout-pricing.js

There's an issue on the codesandbox demo with the currency symbol not rendering correctly. I tested this locally and this is specific to codesandbox and should work fine outside of that environment.

Thanks again for your patience and for reporting and sharing your issue!

@dbrudner dbrudner closed this as completed May 5, 2020
@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented May 7, 2020

@dbrudner Thank you! 🙏 I will try it out as soon as I have time.

@dbrudner
Copy link
Contributor

dbrudner commented May 7, 2020

If you run into any problems, definitely feel free to share them back inside this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants