Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of ForeachItemsAssignToEmptyArrayToAssignRector #8865

Closed
samsonasik opened this issue Oct 20, 2024 · 0 comments · Fixed by rectorphp/rector-src#6390
Closed
Labels

Comments

@samsonasik
Copy link
Member

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/32c57132-506d-4db0-b05f-010de8844ce9

<?php

        $a = ['a'];
        $b = ['b'];
        $c = [];

        // assign
        $c = $a;

        // append after assign
        foreach ($b as $bx) {
            $c[] = $bx;
        }

append after initialization assign with non-empty array should be skipped, as result is different. see

https://3v4l.org/rvVHU vs https://3v4l.org/OaaAN

Responsible rules

  • ForeachItemsAssignToEmptyArrayToAssignRector

Expected Behavior

should be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant