-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP endpoints #26
Comments
It would be nice!
Unfortunately I don't think GitHub pages allows that, so we'd need another host.
Such calls will be blocked by the cross-origin policy unless the service supports CORS. And as far as I can tell HTTP only sites are blocked via both CORS and JSONP for me anyway (with Firefox). |
This still might be useful if you're running the test bench locally. Perhaps it could be conditioned on that. But maybe this is not meant as a test suite when developing reconciliation services. Is it? If not, then testbench might be a bit misleading. I was lead here by someone trying to test a service built with my code still worked. FWIW, I tried running this locally per the README and got the following:
The workaround here seemed to fix it. FWIW, I'm running on OSX 12.0.1 with npm version 8.6.0. |
When running the test bench locally (or any deployment that uses HTTP), HTTP endpoints should be supported.
It is. Also, the HTTPS deployment we offer should also work with endpoints such as
Thanks for reporting! It would be worth opening a new issue about this, because I think this is unrelated to this issue. |
Okay. I'll open a new issue. I don't believe using http:// locally worked for me but maybe I got distracted by a warning pop up. I'll try again and mention it in the new issue if it's a problem. |
In Chrome 87, even allowing "insecure content" for the test bench site, doesn't allow reconciliation services which are served over HTTP to be tested. It would be nice to figure out a way around this without having to go around and implement CORS and/or HTTPS everywhere, but I'm not sure what the options are.
Possibilities?:
As an aside, one of the sites doesn't appear to support JSONP or CORS http://openup.nhm-wien.ac.at/commonNames/?callback=foo returns pure JSON with no callback function wrapper.
The text was updated successfully, but these errors were encountered: