New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] time_now is not implemented in SARplus #1710

Closed

simonzhaoms opened this issue Apr 26, 2022 · 1 comment

Labels

Collaborator

simonzhaoms commented Apr 26, 2022 •

edited

Loading

Description

Just take a look at the code, sarplus only uses the latest timestamp but not time_now. I also find in the tests of sar single node, there are only 2 places involving time_now, but both use the latest timestamp as the value of time_now: https://github.com/microsoft/recommenders/blob/d4181cf1d1df6e71f7e6b202b0875bb3bd54150c/tests/unit/recommenders/models/test_sar_singlenode.py#L237 and https://github.com/microsoft/recommenders/blob/d4181cf1d1df6e71f7e6b202b0875bb3bd54150c/tests/unit/recommenders/models/test_sar_singlenode.py#L201.

Expected behavior with the suggested feature

If time_now is specified, it should be used instead of the latest timestamp.

Other Comments

The text was updated successfully, but these errors were encountered:

simonzhaoms added the enhancement label

simonzhaoms mentioned this issue

Implement time_now for sarplus #1719

Merged

6 tasks

Collaborator Author

simonzhaoms commented May 24, 2022

Implemented by #1719

simonzhaoms closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment