From ff15c4e47615438faa7be3e02192d33678ba6179 Mon Sep 17 00:00:00 2001 From: miguelgfierro Date: Sun, 17 Nov 2024 07:56:29 +0100 Subject: [PATCH 1/6] Update runner to ubuntu-24.04 Signed-off-by: miguelgfierro --- .github/workflows/azureml-cpu-nightly.yml | 2 +- .github/workflows/azureml-gpu-nightly.yml | 2 +- .github/workflows/azureml-release-pipeline.yml | 2 +- .github/workflows/azureml-spark-nightly.yml | 2 +- .github/workflows/azureml-unit-tests.yml | 2 +- .github/workflows/sarplus.yml | 2 +- .github/workflows/update_documentation.yml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/azureml-cpu-nightly.yml b/.github/workflows/azureml-cpu-nightly.yml index 616707f7f..1a147a2ca 100644 --- a/.github/workflows/azureml-cpu-nightly.yml +++ b/.github/workflows/azureml-cpu-nightly.yml @@ -44,7 +44,7 @@ on: jobs: get-test-groups: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Check out repository code uses: actions/checkout@v4 diff --git a/.github/workflows/azureml-gpu-nightly.yml b/.github/workflows/azureml-gpu-nightly.yml index 23cffda0a..2cfd80d7e 100644 --- a/.github/workflows/azureml-gpu-nightly.yml +++ b/.github/workflows/azureml-gpu-nightly.yml @@ -44,7 +44,7 @@ on: jobs: get-test-groups: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Check out repository code uses: actions/checkout@v4 diff --git a/.github/workflows/azureml-release-pipeline.yml b/.github/workflows/azureml-release-pipeline.yml index 983cce9db..66e48ca48 100644 --- a/.github/workflows/azureml-release-pipeline.yml +++ b/.github/workflows/azureml-release-pipeline.yml @@ -29,7 +29,7 @@ jobs: secrets: inherit create-release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [unit-test-workflow, cpu-nightly-workflow, gpu-nightly-workflow, spark-nightly-workflow] steps: - name: Check out repository code diff --git a/.github/workflows/azureml-spark-nightly.yml b/.github/workflows/azureml-spark-nightly.yml index da508ebe4..bb393059c 100644 --- a/.github/workflows/azureml-spark-nightly.yml +++ b/.github/workflows/azureml-spark-nightly.yml @@ -43,7 +43,7 @@ on: jobs: get-test-groups: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Check out repository code uses: actions/checkout@v4 diff --git a/.github/workflows/azureml-unit-tests.yml b/.github/workflows/azureml-unit-tests.yml index 0f7ed2a18..c346edff3 100644 --- a/.github/workflows/azureml-unit-tests.yml +++ b/.github/workflows/azureml-unit-tests.yml @@ -33,7 +33,7 @@ on: jobs: get-test-groups: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Check out repository code uses: actions/checkout@v4 diff --git a/.github/workflows/sarplus.yml b/.github/workflows/sarplus.yml index 90d03fef6..832249c26 100644 --- a/.github/workflows/sarplus.yml +++ b/.github/workflows/sarplus.yml @@ -36,7 +36,7 @@ jobs: # Test pysarplus with different versions of Python. # Package pysarplus and upload as GitHub workflow artifact when merged into # the main branch. - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: matrix: python-version: ["3.8", "3.9", "3.10", "3.11"] diff --git a/.github/workflows/update_documentation.yml b/.github/workflows/update_documentation.yml index 30e2eadf1..bcac8bd2e 100644 --- a/.github/workflows/update_documentation.yml +++ b/.github/workflows/update_documentation.yml @@ -12,7 +12,7 @@ on: jobs: build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Checkout repository From 2f2cf910510a1e85a6ed753e66014c2a99e98be1 Mon Sep 17 00:00:00 2001 From: miguelgfierro Date: Sun, 17 Nov 2024 08:02:07 +0100 Subject: [PATCH 2/6] Timeout update Signed-off-by: miguelgfierro --- .github/workflows/azureml-cpu-nightly.yml | 3 ++- .github/workflows/azureml-gpu-nightly.yml | 3 ++- .github/workflows/azureml-spark-nightly.yml | 3 ++- .github/workflows/azureml-unit-tests.yml | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/azureml-cpu-nightly.yml b/.github/workflows/azureml-cpu-nightly.yml index 1a147a2ca..2f61b0c92 100644 --- a/.github/workflows/azureml-cpu-nightly.yml +++ b/.github/workflows/azureml-cpu-nightly.yml @@ -63,7 +63,8 @@ jobs: execute-tests: needs: get-test-groups name: ${{ join(matrix.*, ', ') }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 + timeout-minutes: 120 permissions: id-token: write # This is required for requesting the JWT strategy: diff --git a/.github/workflows/azureml-gpu-nightly.yml b/.github/workflows/azureml-gpu-nightly.yml index 2cfd80d7e..b69d7fb9f 100644 --- a/.github/workflows/azureml-gpu-nightly.yml +++ b/.github/workflows/azureml-gpu-nightly.yml @@ -63,7 +63,8 @@ jobs: execute-tests: needs: get-test-groups name: ${{ join(matrix.*, ', ') }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 + timeout-minutes: 120 permissions: id-token: write # This is required for requesting the JWT strategy: diff --git a/.github/workflows/azureml-spark-nightly.yml b/.github/workflows/azureml-spark-nightly.yml index bb393059c..7f9987d15 100644 --- a/.github/workflows/azureml-spark-nightly.yml +++ b/.github/workflows/azureml-spark-nightly.yml @@ -62,7 +62,8 @@ jobs: execute-tests: needs: get-test-groups name: ${{ join(matrix.*, ', ') }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 + timeout-minutes: 120 permissions: id-token: write # This is required for requesting the JWT strategy: diff --git a/.github/workflows/azureml-unit-tests.yml b/.github/workflows/azureml-unit-tests.yml index c346edff3..9766d8831 100644 --- a/.github/workflows/azureml-unit-tests.yml +++ b/.github/workflows/azureml-unit-tests.yml @@ -52,7 +52,8 @@ jobs: execute-tests: needs: get-test-groups name: ${{ join(matrix.*, ', ') }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 + timeout-minutes: 120 permissions: id-token: write # This is required for requesting the JWT strategy: From 53b5d53bb85a9948b2dfd113b87e182c630b12e0 Mon Sep 17 00:00:00 2001 From: Simon Zhao Date: Mon, 2 Dec 2024 23:12:07 +0800 Subject: [PATCH 3/6] Install sbt for sarplus tests (#2192) Signed-off-by: Simon Zhao --- .github/workflows/sarplus.yml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sarplus.yml b/.github/workflows/sarplus.yml index 832249c26..5ae935696 100644 --- a/.github/workflows/sarplus.yml +++ b/.github/workflows/sarplus.yml @@ -8,7 +8,7 @@ # * GitHub Actions workflow templates # + [python package](https://github.com/actions/starter-workflows/blob/main/ci/python-package.yml) # + [scala](https://github.com/actions/starter-workflows/blob/main/ci/scala.yml) -# * [GitHub hosted runner - Ubuntu 20.04 LTS](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md) +# * [GitHub hosted runner - Ubuntu 24.04 LTS](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md) # * [Azure Databricks runtime releases](https://docs.microsoft.com/en-us/azure/databricks/release-notes/runtime/releases) # * [Azure Synapse Analytics runtimes](https://docs.microsoft.com/en-us/azure/synapse-analytics/spark/apache-spark-version-support) @@ -53,6 +53,14 @@ jobs: python -m pip install -U build cibuildwheel pip twine python -m pip install -U flake8 pytest pytest-cov scikit-learn + # Install sbt + # See https://github.com/yokra9/akka-http-example/pull/119/files + echo "deb https://repo.scala-sbt.org/scalasbt/debian all main" | sudo tee /etc/apt/sources.list.d/sbt.list + echo "deb https://repo.scala-sbt.org/scalasbt/debian /" | sudo tee /etc/apt/sources.list.d/sbt_old.list + curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" | sudo apt-key add + sudo apt-get update + sudo apt-get install sbt + - name: Lint with flake8 run: | cd "${PYTHON_ROOT}" @@ -133,6 +141,15 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install sbt + run: | + # See https://github.com/yokra9/akka-http-example/pull/119/files + echo "deb https://repo.scala-sbt.org/scalasbt/debian all main" | sudo tee /etc/apt/sources.list.d/sbt.list + echo "deb https://repo.scala-sbt.org/scalasbt/debian /" | sudo tee /etc/apt/sources.list.d/sbt_old.list + curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" | sudo apt-key add + sudo apt-get update + sudo apt-get install sbt + - name: Test run: | cd "${SCALA_ROOT}" From b15263d270c8f3913a90898de8d294306ce8cf17 Mon Sep 17 00:00:00 2001 From: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Date: Sun, 22 Dec 2024 14:28:43 +0100 Subject: [PATCH 4/6] Update Tao's user (#2199) Signed-off-by: miguelgfierro Co-authored-by: miguelgfierro --- .github/CODEOWNERS | 2 +- AUTHORS.md | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 71e970f23..55fe145a4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,5 +1,5 @@ # See https://help.github.com/articles/about-codeowners/ # for more info about CODEOWNERS file -* @miguelgfierro @gramhagen @anargyri @loomlike @wutaomsft @simonyansenzhao +* @miguelgfierro @gramhagen @anargyri @loomlike @wav8k @simonyansenzhao diff --git a/AUTHORS.md b/AUTHORS.md index b70bfa644..da4113c74 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -32,14 +32,13 @@ They have admin access to the repo and provide support reviewing issues and pull * **[Miguel González-Fierro](https://github.com/miguelfierro)** * Recommendation algorithms review, development and optimization. * Reco utils review, development and optimization. - * Github statistics. * Continuous integration build / test setup. * **[Scott Graham](https://github.com/gramhagen)** * Improving documentation * VW notebook * **[Simon Zhao](https://github.com/simonyansenzhao)** * SARplus algorithm upgrade -* **[Tao Wu](https://github.com/wutaomsft)** +* **[Tao Wu](https://github.com/wav8k)** * Improving documentation From 7166fceaefaadc1db0d59b666007877f213c0f76 Mon Sep 17 00:00:00 2001 From: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Date: Sun, 22 Dec 2024 14:29:05 +0100 Subject: [PATCH 5/6] Execute tests when there are changes in the pipelines (#2197) Signed-off-by: miguelgfierro Co-authored-by: miguelgfierro --- .github/workflows/azureml-unit-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/azureml-unit-tests.yml b/.github/workflows/azureml-unit-tests.yml index 9766d8831..b79ff2b79 100644 --- a/.github/workflows/azureml-unit-tests.yml +++ b/.github/workflows/azureml-unit-tests.yml @@ -19,6 +19,7 @@ on: - tests/** - '!tests/**/*.md' - setup.py + - .github/** types: [opened, synchronize, reopened, ready_for_review] # Enable manual trigger From 90b180ad40e922d548231bb70805e35833bfefd3 Mon Sep 17 00:00:00 2001 From: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Date: Sun, 22 Dec 2024 14:29:24 +0100 Subject: [PATCH 6/6] Prepare for release (#2200) * Recommenders 1.2.1 Signed-off-by: miguelgfierro * update readmes Signed-off-by: miguelgfierro * updating the date --------- Signed-off-by: miguelgfierro Co-authored-by: miguelgfierro --- NEWS.md | 6 ++++++ README.md | 6 +++--- recommenders/__init__.py | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/NEWS.md b/NEWS.md index 9d8b1aeb6..40347161f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -5,6 +5,12 @@ Licensed under the MIT License. # What's New +## Update December 23, 2024 + +We have a new release [Recommenders 1.2.1](https://github.com/recommenders-team/recommenders/releases/tag/1.2.1)! + +We fixed a lot of bugs due to dependencies, improved security, reviewed the notebooks and the libraries. + ## Update May 2, 2024 We have a new release [Recommenders 1.2.0](https://github.com/microsoft/recommenders/releases/tag/1.2.0)! diff --git a/README.md b/README.md index 7f78b29f8..a56c1a0d0 100644 --- a/README.md +++ b/README.md @@ -15,11 +15,11 @@ Licensed under the MIT License.
-## What's New (May, 2024) +## What's New (Dec, 2024) -We have a new release [Recommenders 1.2.0](https://github.com/recommenders-team/recommenders/releases/tag/1.2.0)! +We have a new release [Recommenders 1.2.1](https://github.com/recommenders-team/recommenders/releases/tag/1.2.1)! -So many changes since our last release. We have full tests on Python 3.8 to 3.11 (around 1800 tests), upgraded performance in many algorithms, reviewed notebooks, and many more improvements. +We fixed a lot of bugs due to dependencies, improved security, reviewed the notebooks and the libraries. ## Introduction diff --git a/recommenders/__init__.py b/recommenders/__init__.py index 87998b029..a4d40c8f6 100644 --- a/recommenders/__init__.py +++ b/recommenders/__init__.py @@ -2,7 +2,7 @@ # Licensed under the MIT License. __title__ = "Recommenders" -__version__ = "1.2.0" +__version__ = "1.2.1" __author__ = "Recommenders contributors" __license__ = "MIT" __copyright__ = "Copyright 2018-present Recommenders contributors."