Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: STEP 5 Clean up state tree for redux #1177

Closed
duong-se opened this issue May 8, 2020 · 1 comment
Closed

Refactor: STEP 5 Clean up state tree for redux #1177

duong-se opened this issue May 8, 2020 · 1 comment
Assignees
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@duong-se
Copy link
Contributor

duong-se commented May 8, 2020

Background context or User story:

  • Reducer folder is messy
    image
  • Redux state tree is messy
    image

Specification or Acceptance Criteria:

  • Move reducer use for developer to developer folder, admin to admin folder and client to client folder
  • Plat state of developer to developer node, auth to auth.ts node, admin to admin.ts node, and client to client.ts
{
  auth: {
    identity: {},
  },
  developer: {
    scopes: {},
    apps: [],
    error: '',
    isAppLoading: {}
    isDeveloperLoading: {}
  },
  admin: {
    apps: {}
  },
  client: {}
}
  • Use action prefix for action types like
    DEVELOPER_FETCH_APPS
    DEVELOPER_FETCH_APPS_SUCCESS
    DEVELOPER_FETCH_APPS_FAILED

Suggested solution:

  • Move reducer use for developer to developer.ts, admin to admin.ts and client to client.ts
@duong-se duong-se added feature New feature or request front-end Relates to front end issues needs-triage labels May 8, 2020
@duong-se duong-se added this to the Marketplace v2.0 milestone May 8, 2020
@duong-se duong-se changed the title Refactor: Clean up state tree for redux Refactor: STEP 5 Clean up state tree for redux May 8, 2020
@willmcvay willmcvay added marketplace Relates to the Marketplace and removed needs-triage labels May 10, 2020
@nphivu414 nphivu414 self-assigned this Jul 20, 2020
@duong-se
Copy link
Contributor Author

This ticket is no longer correct after we migrate to 3 portal. So who pick this ticket should discuss with the team before implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

No branches or pull requests

3 participants