diff --git a/packages/marketplace/src/components/ui/client-app-detail/client-app-header.tsx b/packages/marketplace/src/components/ui/client-app-detail/client-app-header.tsx index 24a3323f83..38a839142f 100644 --- a/packages/marketplace/src/components/ui/client-app-detail/client-app-header.tsx +++ b/packages/marketplace/src/components/ui/client-app-detail/client-app-header.tsx @@ -3,6 +3,7 @@ import { H2 } from '@reapit/elements' import { FaCheck } from 'react-icons/fa' import { AppDetailModel } from '@reapit/foundations-ts-definitions' import styles from '@/styles/blocks/client-app-header.scss?mod' +import { MEDIA_INDEX } from '@/constants/media' export type ClientAppHeaderProps = { appDetailData: AppDetailModel & { @@ -13,8 +14,8 @@ export type ClientAppHeaderProps = { const ClientAppHeader: React.FC = ({ appDetailData, buttonGroup }) => { const { media } = appDetailData - const appIcon = media?.filter(({ type }) => type === 'icon')[0] - const featureImageSrc = appDetailData?.media?.[1]?.uri + const appIcon = media?.filter(({ type }) => type === 'icon')[MEDIA_INDEX.ICON] + const featureImageSrc = appDetailData?.media?.[MEDIA_INDEX.FEATURE_IMAGE]?.uri return (
diff --git a/packages/marketplace/src/components/ui/standalone-app-detail/app-header.tsx b/packages/marketplace/src/components/ui/standalone-app-detail/app-header.tsx index 5cc3bf3856..5f41846d8e 100644 --- a/packages/marketplace/src/components/ui/standalone-app-detail/app-header.tsx +++ b/packages/marketplace/src/components/ui/standalone-app-detail/app-header.tsx @@ -1,3 +1,4 @@ +// TODO: remove this file after we separated dev & client standalone page import * as React from 'react' import { H2 } from '@reapit/elements' import { FaCheck } from 'react-icons/fa' diff --git a/packages/marketplace/src/constants/media.ts b/packages/marketplace/src/constants/media.ts new file mode 100644 index 0000000000..38decc382b --- /dev/null +++ b/packages/marketplace/src/constants/media.ts @@ -0,0 +1,4 @@ +export const MEDIA_INDEX = { + ICON: 0, + FEATURE_IMAGE: 1, +} diff --git a/packages/marketplace/src/tests/badges/badge-branches.svg b/packages/marketplace/src/tests/badges/badge-branches.svg index e027ee5d2c..c1a519bb90 100644 --- a/packages/marketplace/src/tests/badges/badge-branches.svg +++ b/packages/marketplace/src/tests/badges/badge-branches.svg @@ -1 +1 @@ -Coverage:branchesCoverage:branches71.23%71.23% +Coverage:branchesCoverage:branches70.97%70.97% \ No newline at end of file diff --git a/packages/marketplace/src/tests/badges/badge-functions.svg b/packages/marketplace/src/tests/badges/badge-functions.svg index df2695912a..e429a47265 100644 --- a/packages/marketplace/src/tests/badges/badge-functions.svg +++ b/packages/marketplace/src/tests/badges/badge-functions.svg @@ -1 +1 @@ -Coverage:functionsCoverage:functions81.06%81.06% +Coverage:functionsCoverage:functions80.11%80.11% \ No newline at end of file diff --git a/packages/marketplace/src/tests/badges/badge-lines.svg b/packages/marketplace/src/tests/badges/badge-lines.svg index 21a326b199..52894119cf 100644 --- a/packages/marketplace/src/tests/badges/badge-lines.svg +++ b/packages/marketplace/src/tests/badges/badge-lines.svg @@ -1 +1 @@ -Coverage:linesCoverage:lines91.14%91.14% +Coverage:linesCoverage:lines90.6%90.6% \ No newline at end of file diff --git a/packages/marketplace/src/tests/badges/badge-statements.svg b/packages/marketplace/src/tests/badges/badge-statements.svg index fae4668160..9859dc6c15 100644 --- a/packages/marketplace/src/tests/badges/badge-statements.svg +++ b/packages/marketplace/src/tests/badges/badge-statements.svg @@ -1 +1 @@ -Coverage:statementsCoverage:statements90.2%90.2% +Coverage:statementsCoverage:statements89.62%89.62% \ No newline at end of file