From 14126994823ac30b9e13afb3f0e31927b5c50c02 Mon Sep 17 00:00:00 2001 From: Vu Nguyen Date: Thu, 3 Sep 2020 15:17:27 +0700 Subject: [PATCH] refactor: #2520 remove unused styles + refactor app revision styles (#2554) --- .../components/pages/api-docs/api-docs.tsx | 2 +- .../__styles__/pending-revision-comparison.ts | 119 ++++++++++++++++++ .../app-revision-comparison.test.tsx.snap | 110 ++++++++++++---- .../__snapshots__/diff-checkbox.test.tsx.snap | 9 +- .../__snapshots__/diff-media.test.tsx.snap | 16 ++- .../diff-render-html.test.tsx.snap | 12 +- .../__snapshots__/diff-view.test.tsx.snap | 6 +- .../app-revision-comparison/diff-checkbox.tsx | 10 +- .../app-revision-comparison/diff-media.tsx | 30 +++-- .../diff-render-html.tsx | 11 +- .../app-revision-comparison/diff-viewer.tsx | 7 +- .../__snapshots__/apps.test.tsx.snap | 2 +- .../src/components/pages/apps/apps.tsx | 2 +- .../developer-edit-app.test.tsx.snap | 8 +- .../general-information-section.test.tsx.snap | 16 ++- .../permission-section.test.tsx.snap | 4 +- .../edit-app/general-information-section.tsx | 6 +- .../pages/edit-app/permission-section.tsx | 3 +- .../__snapshots__/help.test.tsx.snap | 12 ++ .../src/components/pages/help/help.tsx | 2 +- .../pages/login/__styles__/login.ts} | 71 +++++------ .../__snapshots__/login.test.tsx.snap | 21 +++- .../src/components/pages/login/login.tsx | 4 +- .../pages/register/__styles__/register.ts | 68 ++++++++++ .../__snapshots__/register.test.tsx.snap | 12 +- .../components/pages/register/register.tsx | 4 +- .../src/components/pages/swagger/swagger.tsx | 2 +- .../pages/webhooks/webhook-edit-modal.tsx | 3 +- .../pages/welcome/__styles__/welcome.ts | 8 ++ .../__snapshots__/welcome.test.tsx.snap | 5 + .../src/components/pages/welcome/welcome.tsx | 22 ++-- .../__snapshots__/categories-list.tsx.snap | 46 ------- .../__snapshots__/category-item.tsx.snap | 15 --- .../ui/__tests__/categories-list.tsx | 25 ---- .../components/ui/__tests__/category-item.tsx | 27 ---- .../src/components/ui/categories-list.tsx | 32 ----- .../src/components/ui/category-item.tsx | 48 ------- .../developer-edition-content.tsx.snap | 4 +- .../__snapshots__/error-content.tsx.snap | 4 +- .../__snapshots__/success-content.tsx.snap | 16 ++- .../developer-edition-content.tsx | 3 +- .../developer-edition-modal/error-content.tsx | 3 +- .../success-content.tsx | 9 +- .../__styles__/help-item-list.ts | 11 ++ .../__snapshots__/help-item-list.tsx.snap | 12 ++ .../__tests__/help-item-list.tsx | 0 .../{ => help-item-list}/help-item-list.tsx | 8 +- .../src/components/ui/help-item-list/index.ts | 3 + .../ui/popup/__styles__/popup.ts} | 11 +- .../__snapshots__/sandbox-pop-up.tsx.snap | 0 .../unsupport-brower-pop-up.tsx.snap | 0 .../{ => popup}/__tests__/sandbox-pop-up.tsx | 0 .../__tests__/unsupport-brower-pop-up.tsx | 0 .../ui/{ => popup}/sandbox-pop-up.tsx | 7 +- .../{ => popup}/unsupport-browser-pop-up.tsx | 7 +- .../src/core/__styles__/colors.ts | 1 + .../src/styles/blocks/app-sidebar.scss | 35 ------ .../src/styles/blocks/categories-list.scss | 38 ------ .../styles/blocks/developer-app-modal.scss | 3 - .../blocks/developer-edition-modal.scss | 4 - .../src/styles/blocks/diff-checkbox.scss | 34 ----- .../src/styles/blocks/diff-media.scss | 64 ---------- .../src/styles/blocks/diff-render-html.scss | 52 -------- .../src/styles/blocks/diff-viewer.scss | 21 ---- .../src/styles/blocks/loader.scss | 51 -------- .../developer-submit-app-successfully.scss | 5 - .../styles/pages/developer-submit-app.scss | 33 ----- .../src/styles/pages/developer-welcome.scss | 20 --- .../src/styles/pages/help.scss | 17 --- .../elements/src/styles/base/utilities.scss | 4 + 70 files changed, 531 insertions(+), 749 deletions(-) create mode 100644 packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__styles__/pending-revision-comparison.ts rename packages/developer-portal/src/{styles/pages/login.scss => components/pages/login/__styles__/login.ts} (59%) create mode 100644 packages/developer-portal/src/components/pages/register/__styles__/register.ts create mode 100644 packages/developer-portal/src/components/pages/welcome/__styles__/welcome.ts delete mode 100644 packages/developer-portal/src/components/ui/__tests__/__snapshots__/categories-list.tsx.snap delete mode 100644 packages/developer-portal/src/components/ui/__tests__/__snapshots__/category-item.tsx.snap delete mode 100644 packages/developer-portal/src/components/ui/__tests__/categories-list.tsx delete mode 100644 packages/developer-portal/src/components/ui/__tests__/category-item.tsx delete mode 100644 packages/developer-portal/src/components/ui/categories-list.tsx delete mode 100644 packages/developer-portal/src/components/ui/category-item.tsx create mode 100644 packages/developer-portal/src/components/ui/help-item-list/__styles__/help-item-list.ts rename packages/developer-portal/src/components/ui/{ => help-item-list}/__tests__/__snapshots__/help-item-list.tsx.snap (95%) rename packages/developer-portal/src/components/ui/{ => help-item-list}/__tests__/help-item-list.tsx (100%) rename packages/developer-portal/src/components/ui/{ => help-item-list}/help-item-list.tsx (82%) create mode 100644 packages/developer-portal/src/components/ui/help-item-list/index.ts rename packages/developer-portal/src/{styles/blocks/sandbox-pop-up.scss => components/ui/popup/__styles__/popup.ts} (60%) rename packages/developer-portal/src/components/ui/{ => popup}/__tests__/__snapshots__/sandbox-pop-up.tsx.snap (100%) rename packages/developer-portal/src/components/ui/{ => popup}/__tests__/__snapshots__/unsupport-brower-pop-up.tsx.snap (100%) rename packages/developer-portal/src/components/ui/{ => popup}/__tests__/sandbox-pop-up.tsx (100%) rename packages/developer-portal/src/components/ui/{ => popup}/__tests__/unsupport-brower-pop-up.tsx (100%) rename packages/developer-portal/src/components/ui/{ => popup}/sandbox-pop-up.tsx (72%) rename packages/developer-portal/src/components/ui/{ => popup}/unsupport-browser-pop-up.tsx (73%) delete mode 100644 packages/developer-portal/src/styles/blocks/app-sidebar.scss delete mode 100644 packages/developer-portal/src/styles/blocks/categories-list.scss delete mode 100644 packages/developer-portal/src/styles/blocks/developer-app-modal.scss delete mode 100644 packages/developer-portal/src/styles/blocks/developer-edition-modal.scss delete mode 100644 packages/developer-portal/src/styles/blocks/diff-checkbox.scss delete mode 100644 packages/developer-portal/src/styles/blocks/diff-media.scss delete mode 100644 packages/developer-portal/src/styles/blocks/diff-render-html.scss delete mode 100644 packages/developer-portal/src/styles/blocks/diff-viewer.scss delete mode 100644 packages/developer-portal/src/styles/blocks/loader.scss delete mode 100644 packages/developer-portal/src/styles/pages/developer-submit-app-successfully.scss delete mode 100644 packages/developer-portal/src/styles/pages/developer-submit-app.scss delete mode 100644 packages/developer-portal/src/styles/pages/developer-welcome.scss delete mode 100644 packages/developer-portal/src/styles/pages/help.scss diff --git a/packages/developer-portal/src/components/pages/api-docs/api-docs.tsx b/packages/developer-portal/src/components/pages/api-docs/api-docs.tsx index 35f89b33ab..202412cdd1 100644 --- a/packages/developer-portal/src/components/pages/api-docs/api-docs.tsx +++ b/packages/developer-portal/src/components/pages/api-docs/api-docs.tsx @@ -1,7 +1,7 @@ import * as React from 'react' import { useHistory } from 'react-router' import ErrorBoundary from '@/components/hocs/error-boundary' -import { UnsupportBrowserPopUp } from '@/components/ui/unsupport-browser-pop-up' +import { UnsupportBrowserPopUp } from '@/components/ui/popup/unsupport-browser-pop-up' import { isIE } from '@/utils/browser' import Routes from '@/constants/routes' import { IFRAME_URLS } from '@/constants/iframe-urls' diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__styles__/pending-revision-comparison.ts b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__styles__/pending-revision-comparison.ts new file mode 100644 index 0000000000..12c1d8376b --- /dev/null +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__styles__/pending-revision-comparison.ts @@ -0,0 +1,119 @@ +import { css } from 'linaria' +import { grey, black, greyLight, greenLighter, redLighter, reapitMidblue } from '@/core/__styles__/colors' + +export const container = css` + background-color: ${greyLight}; + border: 1px solid ${greyLight}; + border-radius: 3px; + padding: 10px; + color: ${black}; + display: flex; + align-items: center; + justify-content: space-between; +` + +export const checkbox = css` + padding: 4px; + display: flex; + align-items: center; + justify-content: center; + border-radius: 4px; + pointer-events: none; +` + +export const green = css` + background-color: ${greenLighter}; +` + +export const red = css` + background-color: ${redLighter}; +` + +export const arrow = css` + font-size: 18px; + color: ${grey}; +` + +export const image = css` + background-size: contain; + background-repeat: no-repeat; + background-position: center; +` + +export const block = css` + border-radius: 4px; + width: 88px; + height: 88px; + display: flex; + align-items: center; + justify-content: center; +` + +export const iconBlock = css` + width: 90px; + height: 90px; +` + +export const iconImage = css` + width: 80px; + height: 80px; +` + +export const mediaBlock = css` + width: 150px; + height: 210px; +` + +export const mediaImage = css` + width: 140px; + height: 200px; +` + +export const diffRenderHtmlContainer = css` + background-color: ${greyLight}; + border: 1px solid ${greyLight}; + border-radius: 3px; + padding: 10px; + color: ${black}; + display: flex; + align-items: center; + + & a { + color: ${reapitMidblue}; + font-weight: bold; + } + + & ul, + & ol { + margin-top: 0; + margin-left: 0; + list-style-position: inside; + + & li div { + display: inline-block; + } + } + + & p { + margin: 1rem 0; + } +` + +export const diffRenderBlock = css` + overflow-wrap: break-word; + border-radius: 4px; + // 4% space for arrow + width: 48%; +` + +export const diffViewerContainer = css` + background-color: ${greyLight}; + border: 1px solid ${greyLight}; + border-radius: 3px; + padding: 10px; + color: ${black}; + + span { + overflow-wrap: break-word; + } +` diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/app-revision-comparison.test.tsx.snap b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/app-revision-comparison.test.tsx.snap index e0d7bf78a0..82d9a87d04 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/app-revision-comparison.test.tsx.snap +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/app-revision-comparison.test.tsx.snap @@ -172,13 +172,17 @@ Get currentString="Peter's Properties" type="words" > -
+
Peter's Amazon @@ -190,11 +194,13 @@ Get Properties Shopping 2 @@ -216,7 +222,9 @@ Get currentString="" type="words" > -
+
-
+
http https @@ -256,11 +268,13 @@ Get :// myawesomeproptechproduct www @@ -272,11 +286,13 @@ Get . io amazon.com/ @@ -298,7 +314,9 @@ Get currentString="" type="words" > -
+
-
+
support VBNApplication @@ -338,11 +360,13 @@ Get @ reapit test @@ -370,13 +394,17 @@ Get currentString="0113 288 2900" type="words" > -
+
0113 0800 @@ -388,11 +416,13 @@ Get 288 279 @@ -404,11 +434,13 @@ Get 2900 7234 @@ -431,13 +463,17 @@ Get currentString="vitae elementum curabitur vitae" type="words" > -
+
vitae Shop @@ -449,11 +485,13 @@ Get elementum millions @@ -465,11 +503,13 @@ Get curabitur of @@ -481,11 +521,13 @@ Get vitae products, never miss amazing deals, compare prices and reviews @@ -520,13 +562,15 @@ Get notifications when a new deal is available." currentString="enim facilisis" > -
+
- +
-
+
-
+
-
+
-
+
-
+
- +
- + +
- +
+
- +
diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/diff-view.test.tsx.snap b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/diff-view.test.tsx.snap index 7ec7dad1fb..9a0e577ced 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/diff-view.test.tsx.snap +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/__tests__/__snapshots__/diff-view.test.tsx.snap @@ -1,13 +1,17 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`DiffViewer should match a snapshot 1`] = ` -
+
abc axxxxxxxxxxxbc diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-checkbox.tsx b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-checkbox.tsx index 5d15359c50..075699d702 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-checkbox.tsx +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-checkbox.tsx @@ -1,5 +1,5 @@ import * as React from 'react' -import styles from '@/styles/blocks/diff-checkbox.scss?mod' +import { checkbox, arrow, container, red, green } from './__styles__/pending-revision-comparison' export interface DiffCheckboxProps { currentChecked: boolean @@ -11,13 +11,13 @@ const DiffCheckbox = ({ currentChecked, changedChecked, dataTest }: DiffCheckbox const changed = currentChecked !== changedChecked return ( -
- +
+ - {changed && } + {changed && } {changed && ( - + )} diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-media.tsx b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-media.tsx index 089f8a52c2..3a64c21f4c 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-media.tsx +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-media.tsx @@ -1,5 +1,17 @@ import * as React from 'react' -import styles from '@/styles/blocks/diff-media.scss?mod' +import { cx } from 'linaria' +import { + iconBlock, + mediaBlock, + iconImage, + mediaImage, + container, + block, + image, + arrow, + red, + green, +} from './__styles__/pending-revision-comparison' export interface DiffMediaProps { currentMedia?: string @@ -8,17 +20,17 @@ export interface DiffMediaProps { } const DiffMedia = ({ currentMedia, changedMedia, type }: DiffMediaProps) => { - const blockStyle = type === 'icon' ? styles.iconBlock : styles.mediaBlock - const imageStyle = type === 'icon' ? styles.iconImage : styles.mediaImage + const blockStyle = type === 'icon' ? iconBlock : mediaBlock + const imageStyle = type === 'icon' ? iconImage : mediaImage const isDiff = currentMedia !== changedMedia return ( -
-
-
+
+
+
- -
-
+ +
+
) diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-render-html.tsx b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-render-html.tsx index 834fda1de4..32e1040e59 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-render-html.tsx +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-render-html.tsx @@ -1,6 +1,7 @@ import * as React from 'react' -import styles from '@/styles/blocks/diff-render-html.scss?mod' +import { cx } from 'linaria' import { HTMLRender } from '@reapit/elements' +import { red, green, diffRenderBlock, arrow, diffRenderHtmlContainer } from './__styles__/pending-revision-comparison' export interface DiffRenderHTMLProps { currentString?: string @@ -10,10 +11,10 @@ export interface DiffRenderHTMLProps { const DiffRenderHTML = ({ currentString, changedString }: DiffRenderHTMLProps) => { const isDiff = currentString !== changedString return ( -
- - - +
+ + +
) } diff --git a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-viewer.tsx b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-viewer.tsx index 24a1e2ebcb..1003022a85 100644 --- a/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-viewer.tsx +++ b/packages/developer-portal/src/components/pages/app-detail/app-revision-modal/app-revision-comparison/diff-viewer.tsx @@ -1,6 +1,7 @@ import * as React from 'react' import * as jsdiff from 'diff' -import styles from '@/styles/blocks/diff-viewer.scss?mod' +import { cx } from 'linaria' +import { diffViewerContainer, green, red } from './__styles__/pending-revision-comparison' export type DiffType = 'chars' | 'words' | 'lines' | 'wordsWithSpace' @@ -20,12 +21,12 @@ const diffTypes = { const DiffViewer = ({ currentString, changedString, type = 'words' }: DiffViewerProps) => { const result = diffTypes[type](currentString, changedString).map((part, index) => { return ( - + {part.value} ) }) - return
{result}
+ return
{result}
} export default DiffViewer diff --git a/packages/developer-portal/src/components/pages/apps/__tests__/__snapshots__/apps.test.tsx.snap b/packages/developer-portal/src/components/pages/apps/__tests__/__snapshots__/apps.test.tsx.snap index 0a90cb88a5..7914d9df9d 100644 --- a/packages/developer-portal/src/components/pages/apps/__tests__/__snapshots__/apps.test.tsx.snap +++ b/packages/developer-portal/src/components/pages/apps/__tests__/__snapshots__/apps.test.tsx.snap @@ -163,7 +163,7 @@ exports[`Login should match a snapshot 1`] = ` loading={false} >
- +
- +
- +
- +
- +
- +
test @@ -41,7 +41,7 @@ exports[`MarketplaceStatusSection should match a snapshot 1`] = ` />
test diff --git a/packages/developer-portal/src/components/pages/edit-app/general-information-section.tsx b/packages/developer-portal/src/components/pages/edit-app/general-information-section.tsx index caebb85fb1..ad4ce57263 100644 --- a/packages/developer-portal/src/components/pages/edit-app/general-information-section.tsx +++ b/packages/developer-portal/src/components/pages/edit-app/general-information-section.tsx @@ -17,7 +17,6 @@ import linkStyles from '@/styles/elements/link.scss?mod' import { useSelector } from 'react-redux' import { selectCategories } from '@/selector/app-categories' import { CategoryModel } from '@reapit/foundations-ts-definitions' -import styles from '@/styles/pages/developer-submit-app.scss?mod' import { formFields } from './form-schema/form-fields' const { name, categoryId, supportEmail, telephone, homePage, launchUri, summary, description } = formFields @@ -128,7 +127,7 @@ const GeneralInformationSection: React.FC = ({ i - +