Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: rename job status succeeded #133

Conversation

diegodelemos
Copy link
Member

  • Renames succeeded to finished as the latter is the one
    described centrally in reana_db.models.WorkflowStatus and
    reana_db.models.JobStatus.

@diegodelemos diegodelemos changed the base branch from master to maint-0.7 February 19, 2021 13:51
@diegodelemos diegodelemos marked this pull request as ready for review February 19, 2021 14:55
@@ -162,7 +162,7 @@ def run(
publisher,
workflow_uuid,
)
if status != "succeeded":
if status != "finished":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the task at all, just speaking my mind.

Maybe we should move JobStatus and WorkflowStatus enums to r-commons so we can use them here directly? If we had had this logic, we would have avoided many PRs for this task.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I agree it is not practical to have the enums in REANA-DB, we have the ticket reanahub/reana-workflow-controller#204 describing it. It is true I thought of it while implementing but the number of changes would have been bigger with higher chances of introducing a bug just before the workshop.

We should give it more priority for next time since it will make the work on future workflow engines easier too.

* Renames ``succeeded`` to ``finished`` as the latter is the one
  described centrally in ``reana_db.models.WorkflowStatus`` and
  ``reana_db.models.JobStatus``.
@diegodelemos diegodelemos force-pushed the reana-461/configurable-job-cleanup-on-failure branch from 2358029 to 79de17f Compare February 22, 2021 20:11
@diegodelemos diegodelemos merged commit 79de17f into reanahub:maint-0.7 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants