Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

installation: remove vmdriver installation step #230

Closed
4 tasks
diegodelemos opened this issue Sep 30, 2019 · 4 comments
Closed
4 tasks

installation: remove vmdriver installation step #230

diegodelemos opened this issue Sep 30, 2019 · 4 comments

Comments

@diegodelemos
Copy link
Member

diegodelemos commented Sep 30, 2019

Currently, we include the Minikube vmdriver installation step in our docs (kvm2, docker-mahcine-driver-hyperkit). From Minikube 1.4.0 this installation is handled by Minikube itself.

Actions:

@diegodelemos diegodelemos changed the title installation: remove hyperkit installation step installation: remove vmdriver installation step Sep 30, 2019
@tiborsimko
Copy link
Member

A related "someday" thought: we could even delete MINIKUBE_DRIVER configuration variable for make and advise people to set their preferred driver via:

$ minikube config set vm-driver kvm2

so that one could use minikube start without specifying the driver parameter.

This would work well for people using only one driver, however for developers using more drivers from time to time on the same box, e.g. to check installation for several drivers, retaining MINIKUBE_DRIVER configuration option would still be useful. Hence it would be better to keep it but simply remove its default value, so that it wouldn't "force" any particular driver (such as virtualbox) over what people have configured via minikube config (such as hyperkit).

P.S. This could be true for the other parameters such as CPU, disk size, etc. We could use minikube config get cpus and use that instead of MINIKUBE_MEMORY environmental variable (which would only be default fall-back in case people have not used minikube config themselves to configure what they want on their boxes).

@diegodelemos
Copy link
Member Author

I think this issue is not relevant anymore since we commit to the VirtualBox driver for an end to end REANA deployment, with all its features. Of course, if someone has let say, high resource consumption problems, they can use a different driver by themselves or we can give advice on how to do it (it should be really easy since kvm2 and hyperkit are installed by the minikube CLI if they are not present so if people want to change they just need to change minikube config set vm-driver kvm2 and minikube start will take care of the installation).

So if you all agree @mvidalgarcia @roksys @tiborsimko I can close it.

@diegodelemos
Copy link
Member Author

So correcting my message. This is not relevant for the current release (v0.6.0) but it might be in the future, so I am moving it to the Triage board.

@diegodelemos
Copy link
Member Author

In the latest REANA versions (from v0.7.0 onwards) Kind is used instead of Minikube so there is no need to worry about VMs (closed by reanahub/reana#353).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants