Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2757: Add Apple Privacy Manifest #6605

Merged
merged 2 commits into from
Apr 17, 2024
Merged

RJS-2757: Add Apple Privacy Manifest #6605

merged 2 commits into from
Apr 17, 2024

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Apr 10, 2024

What, How & Why?

This closes #6547

Looking at realm/realm-swift#8455 for inspiration (aka stealing)

Related to react-native-community/discussions-and-proposals#776

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kneth kneth requested a review from elle-j April 10, 2024 12:37
@cla-bot cla-bot bot added the cla: yes label Apr 10, 2024
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂

@kneth kneth force-pushed the kneth/ios-privacy-manifest branch from ec7a050 to 192a28f Compare April 16, 2024 08:43
@kneth kneth requested a review from kraenhansen April 16, 2024 09:07
@kneth kneth force-pushed the kneth/ios-privacy-manifest branch from 8861ad7 to 851400d Compare April 17, 2024 04:07
@kneth kneth merged commit 9fea251 into main Apr 17, 2024
30 checks passed
@kneth kneth deleted the kneth/ios-privacy-manifest branch April 17, 2024 09:36
kneth added a commit that referenced this pull request Apr 19, 2024
kneth added a commit that referenced this pull request Apr 19, 2024
* Revert " RJS-2757: Add Apple Privacy Manifest (#6605)"
* Remove privacy manifest for iOS
papafe added a commit that referenced this pull request Apr 24, 2024
* main:
  Installing dependencies again after checkout
  [12.7.1] Bump version (#6632)
  RJS-2806: Upgrade to Realm Core v14.5.2 (#6629)
  RJS-2804: remove incorrect privacy manifest for iOS (#6627)
  Adding permissions fix "Resource not accessible by integration"
  RJS-2143: Tests to clarify number conversion (#6623)
  Fixing unstable test (#6625)
  Adding a script to update submodules
  Update to the new documentation URL (#6597)
  Prepare for vNext
  [12.7.0] Bump version (#6622)
  RJS-2757: Add Apple Privacy Manifest (#6605)
  RJS-2784: Clear internal state to avoid crashes when React Native app is reloaded (#6612)
  Use CMake 3.29.2 (#6619)
  RJS-2801: Upgrade to Realm Core v14.5.1 (#6611)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add privacy manifest to apple binaries
3 participants