Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a SchemaParseError that the new parser should use. #5198

Closed
elle-j opened this issue Dec 22, 2022 · 0 comments · Fixed by #5722
Closed

Create a SchemaParseError that the new parser should use. #5198

elle-j opened this issue Dec 22, 2022 · 0 comments · Fixed by #5722

Comments

@elle-j
Copy link
Contributor

elle-j commented Dec 22, 2022

The new schema parser from #5178 is currently throwing either an Error or AssertionError for invalid schemas. A SchemaParseError that extends Error would provide a more suitable exception to throw.

Notes:

  • Wherever assert() is used, the error object will have to be passed to it (rather than just the message).
  • This change may require integrating with the new updates in Core error handling.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant