Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes branch running JSC on iOS throws Properties can only be defined on Objects from realm/lib/extensions.js #4297

Closed
kraenhansen opened this issue Feb 2, 2022 · 11 comments
Assignees
Labels
Needs-Attention Reporter has responded. Review comment. Reproduction-Required

Comments

@kraenhansen
Copy link
Member

kraenhansen commented Feb 2, 2022

Trying to upgrade to 10.20.0-beta.1 but it won't even let me start the app on iOS (10.20.0-alpha.2 worked fine). Note that I'm not using Hermes on iOS (:hermes_enabled => false) but I am using it on Android.

I'm getting Properties can only be defined on Objects from realm/lib/extensions.js on line 364:

Object.defineProperties(
      realmConstructor.App.Sync.Subscriptions,
      getOwnPropertyDescriptors(subscriptionsMethods.static),
    );

Originally posted by @cristianoccazinsp in https://github.com/realm/realm~~js/issues/3940#issuecomment~~1027264594

@kneth
Copy link
Contributor

kneth commented Feb 2, 2022

Partially fixed by #4298

@cristianoccazinsp
Copy link

Any ETA for the next beta release?

@juhasuni
Copy link

juhasuni commented Feb 15, 2022

This bug affects 10.13.0 also, however I only discovered the issue when starting the app using "My Mac" as the target. iOS simulator seems to run fine.

Downgrading to 10.12.0 solved the issue.

@cristianoccazinsp
Copy link

Was this resolved with Beta 2 or not yet?

@kraenhansen
Copy link
Member Author

We havn't been able to reproduce this yet.

@cristianoccazinsp
Copy link

Odd, I consistently get the error by just upgrading to beta1 from alpha2 and doing no code changes.

@kraenhansen
Copy link
Member Author

kraenhansen commented Feb 16, 2022

@cristianoccazinsp did you clear "the usual suspects"? Derived data, Pods, etc.

@takameyer
Copy link
Contributor

I'll add my obligatory xcode cleanup commands here:

rm -rf ios/Pods
rm ios/Podfile.lock
rm -rf ~/Library/Developer/Xcode/DerivedData
npx pod-install

@cristianoccazinsp
Copy link

I did not clear everything, no, just the regular XCode clean.

@cristianoccazinsp
Copy link

Looks like after doing a cleanup and installing beta2, the issue went away.

@fronck fronck added the Waiting-For-Reporter Waiting for more information from the reporter before we can proceed label Feb 17, 2022
@kraenhansen
Copy link
Member Author

@cristianoccazinsp thats great news!
Thanks for trying it out and submitting your findings - this is a great help for us!

@github-actions github-actions bot added Needs-Attention Reporter has responded. Review comment. and removed Waiting-For-Reporter Waiting for more information from the reporter before we can proceed labels Feb 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs-Attention Reporter has responded. Review comment. Reproduction-Required
Projects
None yet
Development

No branches or pull requests

6 participants