NAPI DataView and TypedArray conversions ignore byteOffset

[RedBeard0531]

realm-js/src/node/node_buffer.hpp

Lines 48 to 60 in f2fd5e1

	template <>
	auto get_data<DataView>(DataView data_view)
	{
	auto buffer = data_view.ArrayBuffer();
	return static_cast<const char*>(buffer.Data());
	}
	template <>
	auto get_data<TypedArray>(TypedArray typed_array)
	{
	auto buffer = typed_array.ArrayBuffer();
	return static_cast<const char*>(buffer.Data());
	}

That code should be adding the byte offset of the view to the start address of the ArrayBuffer. Instead, it is just returning the start address with no offsetting.

[sync-by-unito]

➤ JacobOscarGunnarsson commented:

This code has been removed in v12