Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify by unifying build commands #3708

Closed
kraenhansen opened this issue May 3, 2021 · 1 comment · Fixed by #6650
Closed

Simplify by unifying build commands #3708

kraenhansen opened this issue May 3, 2021 · 1 comment · Fixed by #6650
Assignees

Comments

@kraenhansen
Copy link
Member

kraenhansen commented May 3, 2021

Goals

A more approachable developer experience.

Expected Results

The existing build-android.js and build-ios.sh scripts could be build around a shared CLI, to simplify consumption.

A bare "build" NPM script could provide a discoverable method of building for all supported runtimes.

npm run build -- --runtime ios --type Debug --arch x86

As an example, the following NPM scripts could expose discoverable shortcuts to build for the various supported runtimes:

 npm run build:node
 npm run build:ios
 npm run build:android
 npm run build:node:debug
 npm run build:ios:debug
 npm run build:android:debug

Bonus: It would be great to be able to set an environment variable or npm config to skip building Realm JS all together.
This would help simplify the "react native" integration test jobs on GitHub Actions.

Actual Results

These are the commands needed to build the native module to run the integration tests:

Building the native module for Node.js in debug mode:

npx cmake-js -d

Building the native module (xcframework) for the iOS simulator in debug mode:

./scripts/build-ios.sh -c Debug -s

Building the native module (.so) for the Android simulator in debug mode:

node scripts/build-android.js --arch=x86 --build-type=Debug

Version of Realm and Tooling

  • Realm JS SDK Version: develop branch
  • Node or React Native: N/A
  • Client OS & Version: N/A
  • Which debugger for React Native: N/A
@kneth
Copy link
Contributor

kneth commented May 4, 2021

Should it be possible to specify if you want to build with or without sync (option --sync maybe)?

This was referenced May 5, 2021
@kraenhansen kraenhansen self-assigned this May 28, 2024
@kraenhansen kraenhansen linked a pull request May 28, 2024 that will close this issue
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants