Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xcode and Cocoapods for Monorepo #3398

Closed
sync-by-unito bot opened this issue Nov 9, 2020 · 1 comment
Closed

Update Xcode and Cocoapods for Monorepo #3398

sync-by-unito bot opened this issue Nov 9, 2020 · 1 comment
Assignees
@fealebenpae

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 9, 2020 •
edited
Loading

With 3153 we aim to unify the different build systems in realm-js around CMake. However, we still need to maintain some Xcode and Cocoapods projects files for ReactNative iOS consumers.

I propose that we refactor the iOS build files so that they no longer build the SDK from source. Instead, we should use CMake to produce a static library for iOS, and pare down the Xcode and Cocoapods project builds so that they only know how to link against this prebuilt static library, just like we do for ReactNative Android with the prebuilt .so.
@sync-by-unito sync-by-unito bot assigned fealebenpae and unassigned blagoev Jan 4, 2021
@sync-by-unito sync-by-unito bot closed this as completed Mar 16, 2021
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 16, 2021

➤ Yavor Georgiev commented:

Implemented in #3649

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fealebenpae fealebenpae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fealebenpae @blagoev