Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support openID credential for google authentication #3383

Closed
sync-by-unito bot opened this issue Nov 5, 2020 · 3 comments
Closed

support openID credential for google authentication #3383

sync-by-unito bot opened this issue Nov 5, 2020 · 3 comments
Assignees
@kraenhansen

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 5, 2020 •
edited
Loading

No description provided.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 16, 2020

➤ Kræn Hansen commented:

I believe we need alignment on how the SDKs will expose this, since the existing google credentials needs to live alongside these. If we need to rename the existing method and introduce a new method, this needs to be coordinated.

Personally I'm in favour of trying to infer the type of token passed into Credentials.google to decide what payload to send to the server.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2020

➤ Brian Munkholm commented:

[~kraen.hansen] This should be unblocked now. Please check the doc in the linked RPM issue

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 4, 2020

➤ Kenneth Geisshirt commented:

PR: #3440

@sync-by-unito sync-by-unito bot closed this as completed Dec 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kraenhansen kraenhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kraenhansen