Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function::make_callback for JSC #1255

Closed
kristiandupont opened this issue Aug 29, 2017 · 1 comment
Closed

Function::make_callback for JSC #1255

kristiandupont opened this issue Aug 29, 2017 · 1 comment
Assignees
@ashwinphatak
Labels
T-Bug

Comments

@kristiandupont
Copy link
Contributor

#758 introduced Function::make_callback which invokes ::node::MakeCallback. However, for the JSC implementation it uses a regular function call. This will cause React Native to hang in certain cases, leading us to ugly setTimeout hacks. We should fix this.
@blagoev blagoev mentioned this issue Sep 11, 2017
Closed
@blagoev
Copy link
Contributor

blagoev commented Nov 14, 2017

closing this issue as it is not relevant anymore

@blagoev blagoev closed this as completed Nov 14, 2017
@sync-by-unito sync-by-unito bot mentioned this issue Jul 9, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashwinphatak ashwinphatak

Labels
T-Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashwinphatak @kristiandupont @blagoev