Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queries over ill-formatted geospatial data #6989

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Sep 20, 2023

We had a report that running a query over objects that didn't have the expected type property set to 'Point' would throw an exception. This is disruptive and not typical behaviour for queries. Instead, we should ignore those objects and not include them in the result set.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@ironage ironage self-assigned this Sep 20, 2023
@cla-bot cla-bot bot added the cla: yes label Sep 20, 2023
@coveralls-official
Copy link

coveralls-official bot commented Sep 20, 2023

Pull Request Test Coverage Report for Build james.stone_372

  • 33 of 33 (100.0%) changed or added relevant lines in 2 files are covered.
  • 25 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.184%

Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 82.86%
src/realm/array_string.cpp 2 87.78%
src/realm/sync/noinst/client_impl_base.cpp 2 85.37%
src/realm/util/file.cpp 2 81.57%
test/test_thread.cpp 3 66.67%
test/util/compare_groups.cpp 3 54.12%
src/realm/index_string.cpp 6 87.76%
src/realm/sync/noinst/server/server.cpp 6 75.56%
Totals Coverage Status
Change from base Build 1696: 0.01%
Covered Lines: 232372
Relevant Lines: 254839

💛 - Coveralls

Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense.

@ironage ironage merged commit f2e65a1 into master Sep 21, 2023
@ironage ironage deleted the js/geo-queries branch September 21, 2023 17:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants