Actually add full text indexes when processing schema changes that require them #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
reviewed
Jul 24, 2023
| @@ -633,7 +634,16 @@ static void create_initial_tables(Group& group, std::vector<SchemaChange> const& | |||
| } | |||
| void operator()(AddIndex op) | |||
| { | |||
| add_search_index(table(op.object), *op.property, op.type); | |||
| switch (op.type) { | |||
There was a problem hiding this comment.
This should presumably be in add_search_index() rather than duplicating it in each of the cases?
There was a problem hiding this comment.
add_search_index actually already did the right thing and we just weren't calling it right in the additive schema change case.
tgoyne
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This makes processing additive schema changes where one of the changes is adding a full-text search index actually add the full text search index. Without this change synchronized realms opened asynchronously could end up without any of their defined full text search indexes created and full text searches throwing an error with the message
Column has no fulltext index.☑️ ToDos