Reduce the memory footprint of an automatic reset #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sync history can be short circuited because it will be discarded right after `transfer_group()`
tgoyne
reviewed
May 4, 2023
| // away immediately after anyways. This reduces the memory footprint of a client reset. | ||
| ClientReplication* client_repl = dynamic_cast<ClientReplication*>(group_dst.get_replication()); | ||
| REALM_ASSERT_RELEASE(client_repl); | ||
| client_repl->set_short_circuit(true); |
There was a problem hiding this comment.
TempShortCircuitReplication is a helper to do this.
There was a problem hiding this comment.
Just what I needed, thanks! Updated.
tgoyne
approved these changes
May 4, 2023
jbreams
approved these changes
May 4, 2023
michael-wb
approved these changes
May 4, 2023
|
Looks good - thanks for looking into this! We'll see about creating another build tomorrow to see if this helps the customer. |
danieltabacaru
approved these changes
May 4, 2023
|
Incidentally, this also improves performance in cases where the difference of the fresh Realm to the local Realm requires many changes. Running the object-store client reset benchmarks showed improvements in the following scenarios: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync history can be short circuited because it will be discarded right after
transfer_group()I made a temporary client reset test that inserted a bunch of large strings on the server state so that transfer_group had to insert them and recorded the memory use before and after using
/usr/bin/time -l ./test/object-store/realm-object-store-tests.app/Contents/MacOS/realm-object-store-tests "sync: client reset" -c "recovery" -c "insert" -d yesThe amount of memory difference will vary widely based on the actual data, but I take the following improvement from my synthetic test to be an indication of improvement:
Before:
17581760 peak memory footprintAfter:
13338304 peak memory footprint