Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better performance of an IncludeDescriptor #3311

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Jul 2, 2019

Table equality is evaluated by comparing every row, which is a very expensive operation. The intent of the code which checks for table equality can be replaced by checking the table name.

This was discovered by a customer using the includeLinkingObjects feature of subscriptions.

@ironage ironage added the T-Bug label Jul 2, 2019
@ironage ironage requested review from jedelbo and finnschiermer July 2, 2019 09:54
@ironage ironage self-assigned this Jul 2, 2019
@finnschiermer finnschiermer merged commit aca2e12 into master Jul 2, 2019
@ironage ironage deleted the js/query-inclusions-faster branch October 16, 2019 22:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants