Fix spurious incorrect thread exceptions due to threadid reuse #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We key the Realm cache on the thread ID, but thread IDs are not actually unique over the lifetime of the process. This means that the cached Realm may have been created on a different thread with the same ID, which means that it'll be bound to a different runloop than the current thread's runloop. Check for this, and simply open a new Realm instead of reusing the cached Realm when this happens.
jsflax
approved these changes
Aug 20, 2020
leemaguire
approved these changes
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We key the Realm cache on the thread ID, but thread IDs are not actually unique over the lifetime of the process. This means that the cached Realm may have been created on a different thread with the same ID, which means that it'll be bound to a different runloop than the current thread's runloop. Check for this, and simply open a new Realm instead of reusing the cached Realm when this happens.
Fixes #6659. Fixes #6689. Fixes #6712.