Add an option to only set the properties which actually change #6149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
May 21, 2019
| Adds or updates an existing object into the Realm. | ||
| What to do when an object being added to or created in a Realm has a primary key that already exists. | ||
| */ | ||
| public enum UpdatePolicy: Int { |
There was a problem hiding this comment.
Not sure what the thinking was behind choosing these names, but they differ from the ones in Realm JS (which, granted, were kinda arbitrary):
enum UpdateMode {
Never = 'never',
Modified = 'modified',
All = 'all'
}
There was a problem hiding this comment.
I should probably change 'changed' to 'modified' to align them.
'error' is trying to convey that an exception is thrown as opposed to it just not updating the object if it already exists (which is a different thing that might be worth doing).
|
Should we also update the docs (the guide) to mention this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift this is done by changing
update: Booltoupdate: UpdatePolicywith the enum options being.all,.changed, and.error, with a deprecated overload for the old parameter types to avoid breaking backwards compatibility. Objective C uses separate methods for create and createOrUpdate, so this sticks with that pattern and addscreateOrUpdateChangedInRealm:withValue:for the new behavior.Closes #5970.