Stop the document from jumping to the hash when a token is clicked.

[jverkoey]

No description provided.

[jverkoey]

I'm not sure what the best way to stage the integration-specs repo is. It seems that I'd have to land the change in the other repo first in order to reference the commit here. Is that correct?

I'm wondering if instead it's possible to temporarily set the submodule ref to point to my own repo where the relevant integration-specs branch is...

[pcantrell]

@jverkoey Yes, you have to first create a commit in integration-specs before committing the updated reference in jazzy. You also have to make sure that integration-specs is pushed before Travis sees your update to jazzy.

[jpsim]

Ok, I just merged realm/jazzy-integration-specs#7. Could you please update this PR to point the integration specs submodule to that commit?

Change looks good otherwise.

[jpsim]

FYI we only include links to issues, not PRs

[jverkoey]

Ah good to know - will fix.

[jpsim]

Taking this over. Thanks @jverkoey.

[jverkoey]

Ah thank you! I got blocked on updating the specs and then life took hold :p is there any way to more easily generate the specs?

[segiddins]

There's a rake task that rebuilds them

[jpsim]

is there any way to more easily generate the specs?

unfortunately not. you have push access to jazzy-integration-specs, so I suggest you follow these steps when updates are necessary:

git checkout master
git pull
git checkout -
git rebase master
bundle install
bundle exec rake rebuild_integration_fixtures
cd spec/integration_specs
git checkout -b $jazzy_branch_name
git commit -a -m "update for $jazzy_branch_name"
git push
cd ../../
git commit -a -m "update integration specs"
git push

[jverkoey]

Noted :) what's the rationale for having the specs as a separate repo?

[jpsim]

They're quite large.

[jverkoey]

Ah, makes sense. Thanks again!

[jpsim]

Actually, they're really not that large... I'll make a PR merging them back into jazzy proper so we can discuss the tradeoffs

[segiddins]

@jpsim please make the PR from a fork