Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties don't report "get" vs. "set" #225

Closed
stephencelis opened this issue May 5, 2015 · 6 comments
Closed

Properties don't report "get" vs. "set" #225

stephencelis opened this issue May 5, 2015 · 6 comments

Comments

@stephencelis
Copy link
Contributor

It would be great for properties to be given the same treatment they're given in the module interfaces, e.g.,

public var completed: Bool { get }
public var enabled: Bool { get set }
@jpsim
Copy link
Collaborator

jpsim commented May 5, 2015

Agreed! I think the solution here might be to use SourceKit's declaration, which does this automatically. The reason we haven't done that so far is that 1) it doesn't show default argument values (instead showing arg: T = default) and 2) it always uses full type names Swift.String/Foundation.NSDate.

It might be a bit tricky to solve both issues, but I think it's worthwhile.

@stephencelis stephencelis changed the title Computed properties don't report "get" vs. "set" Properties don't report "get" vs. "set" May 6, 2015
@stephencelis
Copy link
Contributor Author

Updated to clarify that this impacts non-computed properties, too.

@jpsim
Copy link
Collaborator

jpsim commented Jun 9, 2016

just an FYI, you get this for the Swift declarations for Objective-C docs now, since those use the generated Swift interface.

@pigeondotdev pigeondotdev self-assigned this Nov 23, 2016
@pigeondotdev
Copy link
Contributor

Seems resolved to me.

just an FYI, you get this for the Swift declarations for Objective-C docs now, since those use the generated Swift interface.

Feel free to re-open if you disagree or if more needs to be done.

@jpsim jpsim reopened this Nov 26, 2016
@jpsim
Copy link
Collaborator

jpsim commented Nov 26, 2016

Reopening since it'd still be useful to do for Swift properties.

@johnfairh
Copy link
Collaborator

Fixed via #902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants