Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inherited isolation parameter to be first in function signatures #5859

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5793.

@SwiftLintBot
Copy link

SwiftLintBot commented Nov 16, 2024

17 Messages
📖 Linting Aerial with this PR took 0.92s vs 0.93s on main (1% faster)
📖 Linting Alamofire with this PR took 1.28s vs 1.29s on main (0% faster)
📖 Linting Brave with this PR took 7.2s vs 7.21s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.14s vs 5.17s on main (0% faster)
📖 Linting Firefox with this PR took 10.74s vs 10.73s on main (0% slower)
📖 Linting Kickstarter with this PR took 9.94s vs 10.16s on main (2% faster)
📖 Linting Moya with this PR took 0.53s vs 0.53s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.92s vs 2.91s on main (0% slower)
📖 Linting Nimble with this PR took 0.78s vs 0.78s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.61s vs 8.84s on main (2% faster)
📖 Linting Quick with this PR took 0.44s vs 0.44s on main (0% slower)
📖 Linting Realm with this PR took 4.55s vs 4.54s on main (0% slower)
📖 Linting Sourcery with this PR took 2.32s vs 2.32s on main (0% slower)
📖 Linting Swift with this PR took 4.55s vs 4.55s on main (0% slower)
📖 Linting VLC with this PR took 1.26s vs 1.26s on main (0% slower)
📖 Linting Wire with this PR took 17.91s vs 17.81s on main (0% slower)
📖 Linting WordPress with this PR took 11.45s vs 11.36s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the isolation-first branch 2 times, most recently from 2ef290b to 9ec1448 Compare November 17, 2024 13:27
@SimplyDanny SimplyDanny enabled auto-merge (squash) November 17, 2024 13:27
@SimplyDanny SimplyDanny merged commit 025b1e7 into realm:main Nov 17, 2024
14 checks passed
@SimplyDanny SimplyDanny deleted the isolation-first branch November 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function_default_parameter_at_end should not trigger for isolated parameter.
2 participants