Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and changelog entry for #1488 #1727

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Add test and changelog entry for #1488 #1727

merged 1 commit into from
Jul 30, 2017

Conversation

marcelofabri
Copy link
Collaborator

#1488 was fixed in #1726.

This adds a test to make sure we don’t introduce regressions in the future and also adds a changelog entry.

#1488 was fixed in #1726.

This adds a test to make sure we don’t introduce regressions in the future and also adds a changelog entry.
@marcelofabri marcelofabri merged commit 359602a into realm:master Jul 30, 2017
@marcelofabri marcelofabri deleted the fix-1488 branch July 30, 2017 15:22
@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.36s vs 0.34s on master (5% slower)
📖 Linting Alamofire with this PR took 2.31s vs 2.33s on master (0% faster)
📖 Linting Firefox with this PR took 9.77s vs 9.76s on master (0% slower)
📖 Linting Kickstarter with this PR took 14.25s vs 14.54s on master (1% faster)
📖 Linting Moya with this PR took 0.69s vs 0.69s on master (0% slower)
📖 Linting Nimble with this PR took 1.32s vs 1.32s on master (0% slower)
📖 Linting Quick with this PR took 0.43s vs 0.43s on master (0% slower)
📖 Linting Realm with this PR took 2.06s vs 2.07s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.76s vs 0.76s on master (0% slower)
📖 Linting Sourcery with this PR took 3.4s vs 3.4s on master (0% slower)
📖 Linting Swift with this PR took 9.63s vs 9.77s on master (1% faster)
📖 Linting WordPress with this PR took 9.33s vs 9.24s on master (0% slower)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants