Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible closure_end_indentation false positive #1216

Closed
keith opened this issue Jan 19, 2017 · 2 comments
Closed

Possible closure_end_indentation false positive #1216

keith opened this issue Jan 19, 2017 · 2 comments
Labels
bug Unexpected and reproducible misbehavior.

Comments

@keith
Copy link
Collaborator

keith commented Jan 19, 2017

foo(foo: bar,
    options: baz) { _ in }

I'm not sure if we want to handle this case, but this is "valid" in our codebase when the first line of the call exceeds our line length limit, but triggers a warning with the closure_end_indentation rule.

// @marcelofabri

@marcelofabri
Copy link
Collaborator

I think this should be valid.

@marcelofabri marcelofabri added the bug Unexpected and reproducible misbehavior. label Jan 19, 2017
@keith
Copy link
Collaborator Author

keith commented Jan 20, 2017

Another case:

foo(abc, 123)
{ _ in }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

No branches or pull requests

2 participants