Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ViolationSeverity to two members: Warning and Error #113

Closed
jpsim opened this issue Aug 31, 2015 · 5 comments
Closed

Reduce ViolationSeverity to two members: Warning and Error #113

jpsim opened this issue Aug 31, 2015 · 5 comments

Comments

@jpsim
Copy link
Collaborator

jpsim commented Aug 31, 2015

As discussed in #106, 5 severity levels is overkill, especially since Xcode can only (really) display 2: warning and error. So this should simplify things quite a bit.

@segiddins
Copy link
Contributor

We could use a third level as note, which should show up in the gutter but not cause build failures.

@jpsim
Copy link
Collaborator Author

jpsim commented Aug 31, 2015

I really don't know when that would be used in practice, I don't think any of SwiftLint's current rules would be appropriate for representation as a "note".

@jpsim
Copy link
Collaborator Author

jpsim commented Aug 31, 2015

It's trivial to add .Note as a case of ViolationSeverity, so we can always add it later if we find a use for it.

@cuddergambino
Copy link

cuddergambino commented Apr 28, 2021

There's a use case I discovered:
Have approaching_expiry_severity: note and expired_severity: warning to only warn of expired todos and note approaching expiries.

I originally was going to make a new request for a none case, but found this issue similar enough. Should I make a new request for this?

@sanguish
Copy link

sanguish commented May 5, 2021

This would be a great solution for these. Since I don't want to see them as a warning before hand.

It's missing from the documentation how to set approaching_expiry_threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants