Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule request: large tuples #1065

Closed
marcelofabri opened this issue Dec 25, 2016 · 5 comments
Closed

Rule request: large tuples #1065

marcelofabri opened this issue Dec 25, 2016 · 5 comments
Labels
rule-request Requests for a new rules.

Comments

@marcelofabri
Copy link
Collaborator

Tuples should have at most 3(?) members.

@marcelofabri marcelofabri added the rule-request Requests for a new rules. label Dec 25, 2016
@doozMen
Copy link

doozMen commented Dec 27, 2016

In my opinion at least 4

@jpsim
Copy link
Collaborator

jpsim commented Dec 27, 2016

Could do warning at 3, error at 4. Configurable for sure.

Could also make exceptions for tuples defined and only used within the scope of a single function, where making a struct might not be worth it.

@marcelofabri
Copy link
Collaborator Author

Probably we should focus on validating function return types first and properties.

@mcfedr
Copy link

mcfedr commented Jan 23, 2017

Sure this should be an opt in type of rule..

Updated swiftlint, project build fails...

@marcelofabri
Copy link
Collaborator Author

@mcfedr You can always disable a rule if you don't think it applies to your project or in this case tune in the limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule-request Requests for a new rules.
Projects
None yet
Development

No branches or pull requests

4 participants