Add OSGi manifest headers #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves to using the biz.aQute.bnd Gradle plugin to produce OSGi-compatible manifests in jar files. Currently, only the aeron-client, aeron-driver, and aeron-cluster modules have been updated to provide OSGi metadata because the other modules are samples, tests, or should never need to be visible inside an OSGi container. Care has been taken to preserve the existing defined manifest fields (Automatic-Module-Name, Implementation-Title, etc). Note that until Agrona 1.0.4 is released (or at least a version containing aeron-io/agrona@49e769e), the generated package imports for Agrona will be unversioned. This will self-correct when Agrona 1.0.4+ is released and Aeron is updated to point to the new version.
|
Please consider, if you have an Aeron release coming up, releasing Agrona first and then pointing Aeron at the new release. 😄 |
|
Thanks. Will do. We will release Agrona early this week. I need it for some other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves to using the biz.aQute.bnd Gradle plugin to
produce OSGi-compatible manifests in jar files. Currently, only the
aeron-client, aeron-driver, and aeron-cluster modules have been updated
to provide OSGi metadata because the other modules are samples, tests,
or should never need to be visible inside an OSGi container. Care
has been taken to preserve the existing defined manifest fields
(Automatic-Module-Name, Implementation-Title, etc).
Note that until Agrona 1.0.4 is released (or at least a version containing
aeron-io/agrona@49e769e),
the generated package imports for Agrona will be unversioned. This will
self-correct when Agrona 1.0.4+ is released and Aeron is updated to
point to the new version.