Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C driver send and receive timestamps #1195

Merged
merged 25 commits into from
Jul 16, 2021
Merged

C driver send and receive timestamps #1195

merged 25 commits into from
Jul 16, 2021

Conversation

mikeb01
Copy link
Contributor

@mikeb01 mikeb01 commented Jun 30, 2021

No description provided.

@mikeb01 mikeb01 force-pushed the c_driver_snd_rcv_timestamps branch from fee6f3e to 5d5f299 Compare July 4, 2021 21:04
@tmontgomery tmontgomery self-requested a review July 12, 2021 16:32
@mjpt777
Copy link
Contributor

mjpt777 commented Jul 13, 2021

I'm not sold on the rx and receive timestamp naming. I wonder if there is better potentially name for rx.

@mikeb01
Copy link
Contributor Author

mikeb01 commented Jul 13, 2021

I picked rx as it matches with the kernel naming for the same timestamp. One option would be to stick with receive but use a qualifying term. E.g. packet receive timestamp and endpoint receive timestamp. pkt-rcv-ts-offset and endpoint-rcv-ts-offset as uri parameter names?

@mjpt777
Copy link
Contributor

mjpt777 commented Jul 14, 2021 •
edited
Loading

@mikeb01 I think that naming is getting better. How about media-rcv-ts-off, aeron-rcv-ts-off? Or some shortening of that?

@mikeb01
Copy link
Contributor Author

mikeb01 commented Jul 14, 2021

media-rcv-ts-off is good, but I think aeron-rcv-ts-off too vague as the whole system is Aeron so that timestamp could be taken anywhere. I'll change rx-ts-offset to media tomorrow and a further think on the other one.

@mjpt777
Copy link
Contributor

mjpt777 commented Jul 14, 2021

We could consider it "channel" receive.

@mikeb01
Copy link
Contributor Author

mikeb01 commented Jul 14, 2021

I think channel works.

mikeb01 added 21 commits July 16, 2021 09:23
@mikeb01
[C] Add send and receive timestamp offset to the uri.
bae353d
@mikeb01
[C] Add receive timestamps to messages. Add clashing checks for recei…
ad2589b 
…ve timestamp configuration. Add validation for overlapping offsets.
@mikeb01
[C] Add receive timestamps to messages. Add clashing checks for recei…
687e68d 
…ve timestamp configuration. Add validation for overlapping offsets.
@mikeb01
[C] Add support for adding send timestamps to the message including p…
842897e 
…ublication clashing validation.
@mikeb01
[C] Support timestamps for MDC messages.
ed3d2a7
@mikeb01
[C] Rename test and fix compile errors.
4583946
@mikeb01
[C] Rename packet timestamp to rx timestamp.
2f3a9ee
@mikeb01
[C] Comments. Put time.h include in header.
e4d6862
@mikeb01
[Java] Naming in error message.
71e21bf
@mikeb01
[C] Revert incorrect renames.
2989f5c
@mikeb01
[Java] Add timestamp fields to ChannelUriStringBuilder.
1894bee
@mikeb01
[C++] Add timestamp offsets to ChannelUriStringBuilder.
9b3fa2c
@mikeb01
[Java] Add receive and send timestamp offsets to UdpChannel.
6b461af
@mikeb01
[Java] Store Receive and Send timestamps in user messages.
147efe2
@mikeb01
[Java] Add endpoint validation for timestamps in Java Driver. Add tes…
a1cbc5f 
…ts for timestamps with MDS and MDC.
@mikeb01
[Java] Checkstyle.
f3048bf
@mikeb01
[Java] Tweak merged MDS timestamp test.
c112269
@mikeb01
[Java] Rename rxTimestampOffset to mediaReceiveTimestampOffset.
4b25df7
@mikeb01
[Java] Rename sendTimestampOffset to channelSendTimestampOffset.
177ccf6
@mikeb01
[Java] Rename receiveTimestampOffset to channelReceiveTimestampOffset.
db50188
@mikeb01
[Java] Tidy up renames and comments/doc.
b829595
@mikeb01 mikeb01 force-pushed the c_driver_snd_rcv_timestamps branch from 3a8b1f9 to b829595 Compare July 15, 2021 23:00
@mjpt777 mjpt777 merged commit 6df4c23 into aeron-io:master Jul 16, 2021
mjpt777 added a commit that referenced this pull request Jul 16, 2021
@mjpt777
[Java] Naming consistency and lambda allocation clean up after merge …
63e8b39 
…of PR #1195.
mjpt777 added a commit that referenced this pull request Jul 16, 2021
@mjpt777
[Java] Allow for timestamping data frames with zero length payload th…
545d1e5 
…at are not heartbeats. PR #1195.
@mikeb01 mikeb01 deleted the c_driver_snd_rcv_timestamps branch October 5, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontgomery tmontgomery tmontgomery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeb01 @mjpt777 @tmontgomery