-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java/C++] Archive variable length recordings. #1069
Merged
mjpt777
merged 52 commits into
aeron-io:master
from
vyazelenko:archive-variable-length-recordings
Nov 13, 2020
Merged
[Java/C++] Archive variable length recordings. #1069
mjpt777
merged 52 commits into
aeron-io:master
from
vyazelenko:archive-variable-length-recordings
Nov 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
971579a
to
09ff33e
Compare
71ac442
to
ce600b7
Compare
ce600b7
to
4df6384
Compare
…num and rename it to `state`.
…ding (i.e. Catalog#maxDescriptorStringsCombinedLength).
…ble-length recording descriptors.
…N_RECORDING` when recording not found or `minRecordingId` is out of range.
…is control request.
…scriptor) + compute alignment/nextRecordingId for old catalog files.
…y#started to support 'jumbo' channel URIs.
…scriptorAtOffset.
…cording scanning.
Address `java.io.IOException: The requested operation cannot be performed on a file with a user-mapped section open` which is thrown on Windows.
…bo recording test pass.
4df6384
to
3d1f621
Compare
mjpt777
reviewed
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Archive recordings from being fixed length (1KB) to variable-length.
Summary:
strippedChannel
,originalChannel
andsourceIdentity
Strings.io.aeron.archive.client.AeronArchive#purgeRecording
), i.e. mark recording asINVALID
and delete the corresponding segment files.max-entries
commands in ArchiveTool have been deprecated in favor ofcapacity
, i.e. Catalog no longer has a max entries limit but has a capacity expressed in bytes. Catalog is auto-growing it's capacity when needed but an explicit command can be used as well.ArchiveTool#compact
to compact the Catalog file, i.e. remove all recordings in stateINVALID
and delete the corresponding segment files.RecordingDescriptorHeader
. Now if theio.aeron.archive.Archive.Context#recordChecksum()
is set the checksum of the entireRecordingDescriptor
will be taken and stored in the header.ArchiveTool#verify
- validateRecordingDescriptor
checksums.ArchiveTool#checksum
- compute and persistRecordingDescriptor
checksums.RecordingDescriptors
, i.e. allowRecordingDescriptors
bigger than thetryClaim
size by usingPublication#offer
API.2
to version3
of the Archive.