Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid archive RecordingDescriptor SBE response length #550

Closed
LiuZhihai opened this issue Sep 4, 2018 · 1 comment
Closed

Invalid archive RecordingDescriptor SBE response length #550

LiuZhihai opened this issue Sep 4, 2018 · 1 comment

Comments

@LiuZhihai
Copy link

Hi, there. I am currently working on implementing the archive client in C++. While implementing listRecording feature, our test program crashed due to malformed SBE message. After few hours of investigation, I think the following line of code caused the problem,

https://github.com/real-logic/aeron/blob/51d1998e80ab7c2927c5140593d806f2342d673b/aeron-archive/src/main/java/io/aeron/archive/ControlResponseProxy.java#L58

The - HEADER_LENGTH part should be removed.
mjpt777 added a commit that referenced this issue Sep 4, 2018
@mjpt777
[Java] Account for message header when claiming space for sending arc…
d7e6108 
…hive recording descriptors. Issue #550.
@mjpt777
Copy link
Contributor

mjpt777 commented Sep 4, 2018

There was a bug but the fix is different to what you suggest. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjpt777 @LiuZhihai