Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix FormInput as textarea caret position when focusing #420

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

diegohaz
Copy link
Member

Closes #418

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #420 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #420      +/-   ##
=========================================
+ Coverage   95.18%   95.2%   +0.01%     
=========================================
  Files          90      90              
  Lines        1351    1356       +5     
  Branches      420     423       +3     
=========================================
+ Hits         1286    1291       +5     
  Misses         65      65
Impacted Files Coverage Δ
packages/reakit/src/Tabbable/Tabbable.ts 90.27% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba4fdb...b809d27. Read the comment docs.

@diegohaz diegohaz merged commit d8e7af3 into master Aug 24, 2019
@diegohaz diegohaz deleted the fix/textarea-caret-position-on-focus branch August 24, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textarea : Can't put caret at a specific position when focusing
2 participants