Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to disable USE_NEW_PIP_RESOLVER (--use-feature=2020-resolver) #7498

Closed
jwhitlock opened this issue Sep 21, 2020 · 5 comments
Closed

Comments

@jwhitlock
Copy link

Details

Expected Result

Our project uses hashes, to validate the signature of package downloads, and constraints, to specify the requirements of requirements. This works with pip 20.2.3, unless the --use-feature=2020-resolver is specified, due to that version not considering hashes in constraints files:

I expected readthedocs.org to continue using the "old" resolver until pip 20.3 was released and it became the default resolver.

Actual Result

With #7412 merged, the documentation is installed with --use-feature=2020-resolver, and the build fails. I am unable to determine how to disable this, with .readthedocs.yaml or in the web-based admin.

@stsewd
Copy link
Member

stsewd commented Sep 21, 2020

Hi, we are testing that feature in some random projects to help identify problems with the new resolver before it's enabled by default the next month. I have removed your project from that test, builds are passing now https://readthedocs.org/projects/ichnaea/builds/11930830/. If someone needs to disable that, opening an issue or emailing us is the path to disable it.

@jakirkham
Copy link
Contributor

jakirkham commented Oct 29, 2020

We are also seeing this in dask-image builds ( https://readthedocs.org/projects/dask-image/builds/12159489/ ). Would it be possible to disable it there as well?

FWIW we use Conda to install dependencies. Not sure if builds using Conda will be able to pick up dev versions of pip (depending on how it is installed). Figured it was worth mentioning in case others using Conda run into this as well 🙂

Edit: Actually I guess we were using too old a version of pip to have this flag. That said, I think since we are using Conda to create the environment, we don't need pip to also install dependencies. Is there a way to configure RTD to use pip to just install our package and nothing else?

@stsewd
Copy link
Member

stsewd commented Oct 29, 2020

@jakirkham yes, this error is bc your conda file is declaring an old version of pip, I have removed your project from that sample. https://readthedocs.org/projects/dask-image/builds/12220295/

@jakirkham
Copy link
Contributor

Thanks! 😄

Is there a way to configure RTD to use pip to just install our package and nothing else?

Any thoughts on this question?

@stsewd
Copy link
Member

stsewd commented Oct 29, 2020

@jakirkham I'm not sure if this is going to work, but you can try with https://docs.readthedocs.io/en/stable/config-file/v2.html#packages

(make sure you read the conda section too, since looks like you are using the version 1 of the config file)

https://github.com/dask/dask-image/blob/master/readthedocs.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants